Fix cljfmt options serialization for format-code#3866
Merged
bbatsov merged 2 commits intoclojure-emacs:masterfrom Mar 11, 2026
Merged
Fix cljfmt options serialization for format-code#3866bbatsov merged 2 commits intoclojure-emacs:masterfrom
bbatsov merged 2 commits intoclojure-emacs:masterfrom
Conversation
Member
|
The changes look good. Don't forget to reflect them in the changelog. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Done, added a changelog entry. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3209.
Summary
cider--nrepl-format-code-request-optionswas dropping non-map cljfmt options.As a result, options like
remove-consecutive-blank-lines?andremove-multiple-non-indenting-spaces?never reached theformat-codenREPL op.This change preserves all options, while keeping special nREPL-dict encoding for
nested map options like
indentsandalias-map.Checks done
Reproduced on pre-fix code (
75dc57ae):(("remove-consecutive-blank-lines?" t) ("remove-multiple-non-indenting-spaces?" t))(nil nil (dict))Applied the fix and re-ran the same evaluation:
(t t (dict "remove-consecutive-blank-lines?" t "remove-multiple-non-indenting-spaces?" t))Ran focused tests after the fix:
eldev -dtT -p test test --file test/cider-client-tests.el .Ran 17 specs, 0 failed