[inspect] Show analytics -> display-analytics

Author: alexander-yakushev

src/orchard/inspect.clj

@@ -43,8 +43,8 @@
    :max-value-length 10000   ; To avoid printing huge graphs and Exceptions.
    :max-coll-size    5
    :max-nested-depth nil
-   :show-analytics-hint   nil
-   :analytics-size-cutoff 100000})
+   :display-analytics-hint nil
+   :analytics-size-cutoff  100000})
 
 (defn- reset-render-state [inspector]
   (-> inspector
@@ -210,15 +210,15 @@
   (sibling* inspector 1))
 
 (defn- validate-config [{:keys [page-size max-atom-length max-value-length
-                                max-coll-size max-nested-depth show-analytics-hint
+                                max-coll-size max-nested-depth display-analytics-hint
                                 analytics-size-cutoff]
                          :as config}]
   (when (some? page-size) (pre-ex (pos-int? page-size)))
   (when (some? max-atom-length) (pre-ex (pos-int? max-atom-length)))
   (when (some? max-value-length) (pre-ex (pos-int? max-value-length)))
   (when (some? max-coll-size) (pre-ex (pos-int? max-coll-size)))
   (when (some? max-nested-depth) (pre-ex (pos-int? max-nested-depth)))
-  (when (some? show-analytics-hint) (pre-ex (= show-analytics-hint "true")))
+  (when (some? display-analytics-hint) (pre-ex (= display-analytics-hint "true")))
   (when (some? analytics-size-cutoff) (pre-ex (pos-int? analytics-size-cutoff)))
   (select-keys config (keys default-inspector-config)))
 
@@ -265,7 +265,7 @@
   (pre-ex (contains? supported-view-modes mode))
   (inspect-render (assoc inspector :view-mode mode)))
 
-(defn show-analytics
+(defn display-analytics
   "Calculates and renders analytics for the current object."
   [{:keys [analytics-size-cutoff value] :as inspector}]
   (inspect-render
@@ -274,7 +274,7 @@
          (assoc :value-analysis
                 (binding [analytics/*size-cutoff* analytics-size-cutoff]
                   (analytics/analytics value)))
-         (dissoc :show-analytics-hint))
+         (dissoc :display-analytics-hint))
      inspector)))
 
 (defn render-onto [inspector coll]
@@ -508,16 +508,16 @@
     inspector))
 
 (defn- render-analytics
-  [{:keys [show-analytics-hint value-analysis] :as inspector}]
-  (if (or value-analysis show-analytics-hint)
+  [{:keys [display-analytics-hint value-analysis] :as inspector}]
+  (if (or value-analysis display-analytics-hint)
     (as-> inspector ins
       (render-section-header ins "Analytics")
       (indent ins)
       (if value-analysis
         (render-value-maybe-expand ins value-analysis)
         (-> ins
             (render-indent)
-            (render-ln "Press 'y' or M-x cider-inspector-show-analytics to analyze this value.")))
+            (render-ln "Press 'y' or M-x cider-inspector-display-analytics to analyze this value.")))
       (unindent ins))
     inspector))
 

test/orchard/inspect_test.clj

@@ -1731,14 +1731,14 @@
       (is+ nil (section "Analytics" rendered))))
 
   (testing "analytics hint is displayed if requested"
-    (let [rendered (-> (inspect {:show-analytics-hint "true"} (range 100)) render)]
+    (let [rendered (-> (inspect {:display-analytics-hint "true"} (range 100)) render)]
       (is+ ["--- Analytics:" [:newline]
-            "  Press 'y' or M-x cider-inspector-show-analytics to analyze this value."
+            "  Press 'y' or M-x cider-inspector-display-analytics to analyze this value."
             [:newline] [:newline]]
            (section "Analytics" rendered))))
 
   (testing "analytics is shown when requested"
-    (let [rendered (-> (range 100) inspect inspect/show-analytics render)]
+    (let [rendered (-> (range 100) inspect inspect/display-analytics render)]
       (is+ ["--- Analytics:" [:newline]
             "  " [:value ":count" pos?] " = " [:value "100" pos?] [:newline]
             "  " [:value ":types" pos?] " = " [:value "{java.lang.Long 100}" pos?] [:newline]
@@ -1751,7 +1751,7 @@
     (let [rendered (-> (range 100)
                        inspect
                        (inspect/refresh {:analytics-size-cutoff 10})
-                       inspect/show-analytics
+                       inspect/display-analytics
                        render)]
       (is+ (matchers/prefix
             ["--- Analytics:" [:newline]