Add clj-kondo linting to tests

Author: solar05

.clj-kondo/config.edn

@@ -1,2 +1,4 @@
 {:output {:progress true
-          :exclude-files ["analysis.cljc" "meta.cljc"]}}
+          :exclude-files ["analysis.cljc" "meta.cljc"]}
+ :linters {:unused-private-var {:level :warning :exclude [orchard.query-test/a-private orchard.query-test/docd-fn]}}}
+

Makefile

@@ -20,7 +20,7 @@ cljfmt:
 	lein with-profile +$(VERSION),+cljfmt cljfmt check
 
 kondo:
-	clj-kondo --lint src
+	clj-kondo --lint src test
 
 # Cloverage can't handle some of the code in this project.  For now we
 # must filter problematic namespaces (`-e`) and tests (`-t`) from

test/orchard/apropos_test.clj

@@ -2,8 +2,8 @@
   (:require
    [clojure.repl :as repl]
    [clojure.string :as str]
-   [clojure.test :refer :all]
-   [orchard.apropos :refer :all]
+   [clojure.test :refer [are deftest is testing]]
+   [orchard.apropos :refer [find-symbols]]
    [orchard.meta :refer [var-name var-doc]]))
 
 (def ^{:doc "Test1. Test2. Test3."} public-var [1 2 3])

test/orchard/cljs/env_test.cljc

@@ -1,6 +1,6 @@
 (ns orchard.cljs.env-test
   (:require [clojure.set :as set]
-            [clojure.test :as test #?(:clj :refer :cljs :refer-macros) [deftest is testing use-fixtures]]
+            [clojure.test :as test #?(:clj :refer :cljs :refer-macros) [deftest is testing]]
             [orchard.cljs.analysis :as a]
             [orchard.cljs.test-env :as test-env]))
 

test/orchard/cljs/meta_test.cljc

@@ -1,5 +1,5 @@
 (ns orchard.cljs.meta-test
-  (:require [clojure.test :as test #?(:clj :refer :cljs :refer-macros) [deftest is testing]]
+  (:require [clojure.test :as test #?(:clj :refer :cljs :refer-macros) [deftest is]]
             [orchard.cljs.meta :as cljs-meta]))
 
 (deftest unquote-test

test/orchard/eldoc_test.clj

@@ -1,6 +1,6 @@
 (ns orchard.eldoc-test
   (:require
-   [clojure.test :refer :all]
+   [clojure.test :refer [deftest is testing]]
    [orchard.eldoc :as eldoc]
    [orchard.info :as info]))
 

test/orchard/info_test.clj

@@ -5,8 +5,8 @@
    [orchard.info :as info]
    [orchard.java :as java]
    [orchard.misc :as misc]
+   [clojure.java.io :refer [resource]]
    [orchard.cljs.test-env :as test-env]
-   [orchard.meta :as meta]
    [orchard.test-ns]))
 
 @java/cache-initializer ;; make tests more deterministic
@@ -500,19 +500,19 @@
 
 ;; TODO: Assess the value of this test
 (deftest javadoc-url-test
-  (if (= misc/java-api-version 7)
+  (when (= misc/java-api-version 7)
     (testing "java 1.7"
       (is (= "java/lang/StringBuilder.html#charAt(int)"
              (-> (info/info-java 'java.lang.StringBuilder 'charAt)
                  (get :javadoc))))))
 
-  (if (= misc/java-api-version 8)
+  (when (= misc/java-api-version 8)
     (testing "java 1.8"
       (is (= "java/lang/StringBuilder.html#charAt-int-"
              (-> (info/info-java 'java.lang.StringBuilder 'charAt)
                  (get :javadoc))))))
 
-  (if (= misc/java-api-version 9)
+  (when (= misc/java-api-version 9)
     (testing "java 9"
       (is (= "java/lang/StringBuilder.html#charAt-int-"
              (-> (info/info-java 'java.lang.StringBuilder 'charAt)
@@ -528,7 +528,7 @@
   (:resource (info/file-info x)))
 
 (deftest resource-path-test
-  (is (= (class (file (subs (str (clojure.java.io/resource "clojure/core.clj")) 4)))
+  (is (= (class (file (subs (str (resource "clojure/core.clj")) 4)))
          java.net.URL))
   (is (= (class (file "clojure/core.clj"))
          java.net.URL))

test/orchard/inspect_test.clj

@@ -1,6 +1,6 @@
 (ns orchard.inspect-test
   (:require
-   [clojure.test :refer :all]
+   [clojure.test :refer [deftest is are testing]]
    [orchard.inspect :as inspect]))
 
 (def nil-result ["(\"nil\" (:newline))"])
@@ -238,7 +238,7 @@
 
 (deftype MyTestType [name]
   IMyTestType
-  (get-name [this] name))
+  (get-name [_this] name))
 
 (defmethod inspect/inspect-value MyTestType [obj]
   (str "#<MyTestType " (get-name obj) ">"))

test/orchard/java/classpath_test.clj

@@ -3,7 +3,7 @@
    [clojure.java.io :as io]
    [clojure.set :as set]
    [clojure.string :as str]
-   [clojure.test :refer :all]
+   [clojure.test :refer [deftest is testing]]
    [orchard.java.classpath :as cp]
    [orchard.misc :as misc])
   (:import

test/orchard/java_test.clj

@@ -2,9 +2,9 @@
   (:require
    [clojure.java.io :as io]
    [clojure.java.javadoc :as javadoc]
-   [clojure.test :refer :all]
+   [clojure.test :refer [deftest is are testing]]
    [dynapath.util :as dp]
-   [orchard.java :refer :all]
+   [orchard.java :refer [cache class-info class-info* javadoc-url jdk-find jdk-sources jdk-tools member-info resolve-class resolve-javadoc-path resolve-member resolve-symbol resolve-type source-info]]
    [orchard.misc :as misc]))
 
 (def jdk-parser? (or (>= misc/java-api-version 9) jdk-tools))