Makeclasspath-namespaces resilient to faulty ns declarations (#159)

Fixes #158

Author: mk

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Changelog
 
 ## master (unreleased)
+* [#158](https://github.com/clojure-emacs/orchard/issues/158): Make classpath-namespaces resilient to faulty ns declarations.
 
 ## 0.9.2 (2022-02-22)
 

src/orchard/namespace.clj

@@ -31,7 +31,8 @@
         (cond
           (#{::eof ::fail} found) nil
           (and (list? found)
-               (-> found first #{`ns 'ns}))
+               (-> found first #{`ns 'ns})
+               (symbol? (second found)))
           (second found)
           :else (recur))))))
 

test/orchard/namespace_test.clj

@@ -62,6 +62,9 @@
       (testing "when multiple ns forms are present"
         (spit url "(ns ns1) (ns ns2) (ns ns3)")
         (is (= 'ns1 (sut/read-namespace uri))))
+      (testing "when ns form is invalid"
+        (spit url "(ns (:require [clojure.string]))")
+        (is (nil? (sut/read-namespace uri))))
       (testing "of top-level forms only"
         (spit url "(comment (ns ns1)) (ns ns2) (ns ns3)")
         (is (= 'ns2 (sut/read-namespace uri))))