Upgrade and satisfy Eastwood

Author: vemv

project.clj

@@ -66,12 +66,13 @@
                                           with-debug-bindings [[:inner 0]]
                                           merge-meta [[:inner 0]]
                                           try-if-let [[:block 1]]}}}]
-             :eastwood {:plugins         [[jonase/eastwood "0.9.1"]]
+             :eastwood {:plugins         [[jonase/eastwood "0.9.9"]]
                         :eastwood {;; vendored - shouldn't be tweaked for satisfying linters:
                                    :exclude-namespaces [refactor-nrepl.ns.slam.hound.regrow]
                                    ;; :implicit-dependencies would fail spuriously when the CI matrix runs for Clojure < 1.10,
                                    ;; because :implicit-dependencies can only work for a certain corner case starting from 1.10.
                                    :exclude-linters [:implicit-dependencies]
+                                   :add-linters [:performance :boxed-math]
                                    :config-files ["eastwood.clj"]}}
              :clj-kondo [:test
                          {:dependencies [[clj-kondo "2021.06.18"]]}]}

src/refactor_nrepl/artifacts.clj

@@ -37,7 +37,9 @@
   []
   (or (empty? @artifacts)
       (if-let [last-modified (some-> artifacts meta :last-modified)]
-        (neg? (- millis-per-day (- (.getTime (java.util.Date.)) last-modified)))
+        (neg? (- (long millis-per-day)
+                 (long (- (.getTime (java.util.Date.))
+                          (long last-modified)))))
         true)))
 
 (defn- edn-read-or-nil

src/refactor_nrepl/core.clj

@@ -293,9 +293,9 @@
   (let [^clojure.lang.PersistentVector gen-class (some-> ns-form
                                                          (get-ns-component :gen-class)
                                                          vec)
-        methods_index (inc (if-not (nil? gen-class)
-                             (.indexOf gen-class :methods)
-                             -1))]
+        methods_index (if-not (nil? gen-class)
+                        (-> gen-class (.indexOf :methods) inc)
+                        0)]
     (if-not (zero? methods_index)
       (apply merge (map #(meta %) (nth gen-class methods_index)))
       nil)))
@@ -406,7 +406,9 @@
   "Guard the evaluation of `body` with a test on the current clojure version."
   {:style/indent 1}
   [{:keys [major minor] :as _clojure-version} & body]
-  (when (or (> (:major *clojure-version*) major)
-            (and (= (:major *clojure-version*) major)
-                 (>= (:minor *clojure-version*) minor)))
-    `(do ~@body)))
+  (let [major (long major)
+        minor (long minor)]
+    (when (or (> (-> *clojure-version* :major long) major)
+              (and (= (-> *clojure-version* :major long) major)
+                   (>= (-> *clojure-version* :minor long) minor)))
+      `(do ~@body))))