Skip to content

Commit 38e8f3f

Browse files
Rewrite the dollar symbol test
using incanter was not a good idea after all
1 parent 25a1583 commit 38e8f3f

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

project.clj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
:filespecs [{:type :bytes :path "refactor-nrepl/refactor-nrepl/project.clj" :bytes ~(slurp "project.clj")}]
2222
:profiles {:provided {:dependencies [[cider/cider-nrepl "0.10.0"]
2323
[org.clojure/clojure "1.7.0"]]}
24-
:test {:dependencies [[print-foo "1.0.1"]
25-
[incanter/incanter-core "1.5.7"]]
24+
:test {:dependencies [[print-foo "1.0.1"]]
2625
:src-paths ["test/resources"]}
2726
:1.8 {:dependencies [[org.clojure/clojure "1.8.0"]]}
2827
:1.9 {:dependencies [[org.clojure/clojure "1.9.0-alpha14"]

test/refactor_nrepl/ns/clean_ns_test.clj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343

4444
(def ns-with-inner-classes (clean-msg "test/resources/ns_with_inner_classes.clj"))
4545

46-
(def ns-with-incanter (clean-msg "test/resources/ns_with_incanter.clj"))
46+
(def ns-using-dollar (clean-msg "test/resources/ns_using_dollar.clj"))
4747

4848
(deftest combines-requires
4949
(let [requires (core/get-ns-component (clean-ns ns2) :require)
@@ -205,7 +205,7 @@
205205
(is (re-find #"\^:multiple" cleaned))))
206206

207207
(deftest does-not-remove-dollar-sign-if-valid-symbol
208-
(let [cleaned (pprint-ns (clean-ns ns-with-incanter))]
208+
(let [cleaned (pprint-ns (clean-ns ns-using-dollar))]
209209
(is (re-find #"\[\$\]" cleaned))))
210210

211211
(deftest does-not-break-import-for-inner-class

test/resources/ns_with_incanter.clj renamed to test/resources/ns_using_dollar.clj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
(ns resources.ns-with-incanter
1+
(ns resources.ns-using-dollar
22
(:require [clojure.string :as string]
33
[clojure.set :as set]
4-
[incanter.core :refer [$]]))
4+
[resources.ns-with-dollar-symbol :refer [$]]))
55

66
$
77

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
(ns resources.ns-with-dollar-symbol)
2+
3+
(defn $ []
4+
(println "dollar"))

0 commit comments

Comments
 (0)