Skip to content

Commit 5589052

Browse files
committed
[Fix #269] Ensure namespace sorting does all comparisons as strings
shadow-cljs supports string namespaces for requiring NPM dependencies, eg: (:require [reagent.core :as r] ["react-virtualized/dist/commonjs/List" :refer [List]]) By comparing all namespaces as strings, we fix a ClassCast crash trying to compare such a string to a normal symbol.
1 parent a2eeeef commit 5589052

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/refactor_nrepl/ns/libspecs.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
(defn- aliases-by-frequencies [libspecs]
1717
(->> libspecs
1818
(mapcat aliases) ; => [[str clojure.string] ...]
19-
(sort-by second)
19+
(sort-by (comp str second))
2020
(group-by first) ; => {str [[str clojure.string] [str clojure.string]] ...}
2121
(map (comp seq frequencies second)) ; => (([[set clojure.set] 4] [set set] 1) ...)
2222
(map (partial sort-by second >)) ; by decreasing frequency

0 commit comments

Comments
 (0)