Fix libspec-allowlist

Fixes #363

Author: vemv

src/refactor_nrepl/ns/libspec_allowlist.clj

@@ -3,6 +3,7 @@
    [clojure.java.io :as io]
    [refactor-nrepl.config :as config])
   (:import
+   (clojure.lang IFn)
    (java.util.regex Pattern)))
 
 (defn- libspec-allowlist* []
@@ -20,7 +21,7 @@
                    entry)))
          (into (:libspec-whitelist config/*config*)))))
 
-(def ^:private ^:dynamic *libspec-allowlist* nil)
+(def ^:private ^:dynamic ^IFn *libspec-allowlist* nil)
 
 (defn with-memoized-libspec-allowlist* [f]
   (binding [*libspec-allowlist* (memoize libspec-allowlist*)]
@@ -32,7 +33,7 @@
 
   Uses a memoized version if available."
   []
-  (or *libspec-allowlist*
+  (or (some-> *libspec-allowlist* .invoke)
       (libspec-allowlist*)))
 
 (defmacro with-memoized-libspec-allowlist

test/refactor_nrepl/ns/libspec_allowlist_test.clj

@@ -4,7 +4,7 @@
    [refactor-nrepl.ns.libspec-allowlist :as sut]
    [refactor-nrepl.ns.prune-dependencies :as prune-dependencies]))
 
-(deftest libspec-allowlist
+(deftest libspec-allowlist-test
   (testing "Takes into account refactor-nrepls own config, and .clj-kondo/config files alike,
 merging their results"
     (is (= [;; From refactor-nrepl's default config:
@@ -29,4 +29,9 @@ effecively parsing its config into well-formed regexes"
         'sample.unused.namespaceB  false
         'more.unused.namespaces    true
         'more.unused.namespacessss true
-        'more.unused.namespac      false))))
+        'more.unused.namespac      false))
+
+    (testing "Always returns a sequence, memoized or not"
+      (is (seq (sut/with-memoized-libspec-allowlist
+                 (sut/libspec-allowlist))))
+      (is (seq (sut/libspec-allowlist))))))