Enable and satisfy clj-kondo in test/ (#323)

Author: vemv

.clj-kondo/config.edn

@@ -1,2 +1,4 @@
-{:linters {:unresolved-symbol {:exclude [(refactor-nrepl.ns.ns-parser/with-libspecs-from [libspecs])]}
+;; `nrepl.core/code` can contain intentionally broken code in the test suite, so we silence related resolution errors:
+{:lint-as {nrepl.core/code clojure.core/quote}
+ :linters {:unresolved-symbol {:exclude [(refactor-nrepl.ns.ns-parser/with-libspecs-from [libspecs])]}
            :unresolved-namespace {:exclude [clojure.main]}}}

Makefile

@@ -18,7 +18,7 @@ eastwood:
 	lein with-profile -user,+$(VERSION),+eastwood eastwood
 
 kondo:
-	lein with-profile -dev,+$(VERSION),+clj-kondo run -m clj-kondo.main --lint src 
+	lein with-profile -dev,+$(VERSION),+clj-kondo run -m clj-kondo.main --lint src test
 
 # When releasing, the BUMP variable controls which field in the
 # version string will be incremented in the *next* snapshot

test/global_test_setup.clj

@@ -1,11 +1,13 @@
 (ns global-test-setup
   "This namespace's contents will be automatically loaded by `lein test` (or any test runner).")
 
-(try
-  (require '[refactor-nrepl.inlined-deps.toolsnamespace.v1v1v0.clojure.tools.namespace.repl :refer [set-refresh-dirs]])
-  (catch Exception _
-    (require
-     '[clojure.tools.namespace.repl :refer [set-refresh-dirs]])))
+(def set-refresh-dirs
+  (try
+    (require '[refactor-nrepl.inlined-deps.toolsnamespace.v1v1v0.clojure.tools.namespace.repl :refer [set-refresh-dirs]])
+    @(resolve 'refactor-nrepl.inlined-deps.toolsnamespace.v1v1v0.clojure.tools.namespace.repl/set-refresh-dirs)
+    (catch Exception _
+      (require '[clojure.tools.namespace.repl])
+      @(resolve 'clojure.tools.namespace.repl/set-refresh-dirs))))
 
 (when (System/getenv "CI") ; don't alter local environments (which may also use clojure.tools.namespace.repl)
   ;; Intentionally exclude the `lein-plugin/` source path:

test/refactor_nrepl/artifacts_test.clj

@@ -1,7 +1,7 @@
 (ns refactor-nrepl.artifacts-test
   (:require [clojure
              [edn :as edn]
-             [test :refer :all]]
+             [test :refer [deftest is testing]]]
             [clojure.java.io :as io]
             [refactor-nrepl.artifacts :as artifacts]))
 

test/refactor_nrepl/client.clj

@@ -1,12 +1,11 @@
 (ns refactor-nrepl.client
   (:require [clojure
-             [edn :as edn]
-             [string :as str]]
+             [edn :as edn]]
             [nrepl.core :as nrepl])
-  (:import java.io.File))
+  (:import (java.io File)))
 
 (def ^:private nrepl-port
-  (when (.exists (java.io.File. ".nrepl-port"))
+  (when (.exists (File. ".nrepl-port"))
     (-> ".nrepl-port" slurp Integer/parseInt)))
 
 (def ^:private transp (atom nil))
@@ -42,7 +41,7 @@
                            (#(if file (assoc % :file file) %))
                            (nrepl-message 60000 tr)
                            (map (juxt :occurrence :count :error)))]
-    (if-let [error (some last found-symbols)]
+    (when-let [error (some last found-symbols)]
       (throw (IllegalStateException. (str error))))
     (->> found-symbols
          (map first)
@@ -51,7 +50,7 @@
          (map action)
          doall)))
 
-(defn- prettify-found-symbol-result [{:keys [line-beg name file match]}]
+(defn- prettify-found-symbol-result [{:keys [line-beg _name file match]}]
   (->> match
        (str file " " "[" line-beg "]" ": ")))
 

test/refactor_nrepl/config_test.clj

@@ -1,6 +1,5 @@
 (ns refactor-nrepl.config-test
-  (:require [clojure.set :as set]
-            [clojure.test :refer :all]
+  (:require [clojure.test :refer [deftest is testing]]
             [refactor-nrepl
              [analyzer :as analyzer]
              [config :as sut]]))

test/refactor_nrepl/core_test.clj

@@ -1,5 +1,5 @@
 (ns refactor-nrepl.core-test
-  (:require [clojure.test :refer :all]
+  (:require [clojure.test :refer [deftest is testing]]
             [refactor-nrepl.config :as config]
             [refactor-nrepl.core :refer [ignore-dir-on-classpath?]]))
 

test/refactor_nrepl/extract_definition_test.clj

@@ -1,6 +1,6 @@
 (ns refactor-nrepl.extract-definition-test
   (:require [clojure.java.io :as io]
-            [clojure.test :refer :all]
+            [clojure.test :refer [deftest is]]
             [refactor-nrepl.extract-definition :as sut]
             [refactor-nrepl.unreadable-files :refer [ignore-errors-str]]))
 

test/refactor_nrepl/find/find_macros_test.clj

@@ -1,5 +1,5 @@
 (ns refactor-nrepl.find.find-macros-test
-  (:require [clojure.test :refer :all]
+  (:require [clojure.test :refer [deftest is testing]]
             [refactor-nrepl.find.find-macros :refer [find-macro]]
             [refactor-nrepl.unreadable-files :refer [ignore-errors?]]))
 

test/refactor_nrepl/integration_tests.clj

@@ -1,14 +1,10 @@
 (ns refactor-nrepl.integration-tests
-  (:require [clojure.java.io :as io]
-            [clojure.test :refer :all]
+  (:require [clojure.test :refer [deftest is use-fixtures]]
             [nrepl.server :as nrepl]
             [refactor-nrepl middleware
              [analyzer :as analyzer]
-             [client :refer :all]
-             [core :as core]]
-            [clojure.string :as str])
-  (:import java.io.File
-           org.apache.commons.io.FileUtils))
+             [client :refer [connect find-unbound find-usages resolve-missing version]]
+             [core :as core]]))
 
 (defn start-up-repl-server []
   (let [server