[Fix #231] Drop support for hotloading dependencies

Alembic doesn't work anymore and other better solutions are coming down
the line, so this is disabled for now..

Author: expez

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Changelog
 
 ## Unreleased
+* [#231](https://github.com/clojure-emacs/refactor-nrepl/issues/231) hotload-dependencies temporarily disabled due to java 10 issues.
 * [#215](https://github.com/clojure-emacs/refactor-nrepl/issues/215) Support JVM system proxy in mvn artifacts listing
 * [#198](https://github.com/clojure-emacs/refactor-nrepl/issues/187) Delay middleware loading to speed up initialization.
 * Bump [mranderson](https://github.com/benedekfazekas/mranderson) version to fix leiningen 2.8.x incompatibility issues

project.clj

@@ -6,7 +6,6 @@
   :dependencies [[org.clojure/tools.nrepl "0.2.13"]
                  ^:source-dep [http-kit "2.2.0"]
                  ^:source-dep [cheshire "5.8.0"]
-                 ^:source-dep [alembic "0.3.2"]
                  ^:source-dep [org.clojure/tools.analyzer.jvm "0.7.1"]
                  ^:source-dep [org.clojure/tools.namespace  "0.3.0-alpha3"]
                  ^:source-dep [org.clojure/tools.reader "1.1.1"]

src/refactor_nrepl/artifacts.clj

@@ -1,6 +1,5 @@
 (ns refactor-nrepl.artifacts
-  (:require [alembic.still :as alembic]
-            [cheshire.core :as json]
+  (:require [cheshire.core :as json]
             [clojure
              [edn :as edn]
              [string :as str]]
@@ -107,53 +106,6 @@
        reverse
        list*))
 
-(defn- make-resolve-missing-aware-of-new-deps
-  "Once the deps are available on cp we still have to load them and
-  reset slamhound's cache to make resolve-missing work."
-  [coords repos]
-  (let [dep (->> (alembic/resolve-dependencies alembic/the-still coords repos nil)
-                 (some (fn [dep] (when (= (:coords dep) (first coords)) dep))))
-        jarfile (JarFile. (:jar dep))]
-    (doseq [namespace (find/find-namespaces-in-jarfile jarfile)]
-      (try
-        (require namespace)
-        (catch Exception _
-          ;; I've seen this happen after adding core.async as a dependency.
-          ;; It also happens if you try to require namespaces that no longer work,
-          ;; like compojure.handler.
-          ;; A failure here isn't a big deal, it only means that resolve-missing
-          ;; isn't going to work until the namespace has been loaded manually.
-          )))
-    (slamhound/reset)
-    (slamhound-regrow/clear-cache!)))
-
-(defn- ensure-quality-coordinates [coordinates]
-  (let [coords (->> coordinates read-string (take 2) vec)]
-    (when-not (= (count coords) 2)
-      (throw (IllegalArgumentException. (str "Malformed dependency vector: "
-                                             coordinates))))
-    (when (stale-cache?)
-      (update-artifact-cache!))
-    (if-let [versions (get @artifacts (str (first coords)))]
-      (when-not ((set versions) (second coords))
-        (throw (IllegalArgumentException.
-                (str "Version " (second coords)
-                     " does not exist for " (first coords)
-                     ". Available versions are " (pr-str (vec versions))))))
-      (throw (IllegalArgumentException. (str "Can't find artifact '"
-                                             (first coords) "'"))))))
-
-(defn distill [coords repos]
-  ;; Just so we can mock this out during testing
-  (alembic/distill coords :repositories repos))
-
 (defn hotload-dependency
   [{:keys [coordinates]}]
-  (let [dependency-vector (edn/read-string coordinates)
-        coords [(->> dependency-vector (take 2) vec)]
-        repos {"clojars" "http://clojars.org/repo"
-               "central" "http://repo1.maven.org/maven2/"}]
-    (ensure-quality-coordinates coordinates)
-    (distill coords repos)
-    (make-resolve-missing-aware-of-new-deps coords repos)
-    (str/join " " dependency-vector)))
+  (throw (IllegalArgumentException. "Temporarily disabled until a solution for java 10 is found.")))

test/refactor_nrepl/artifacts_test.clj

@@ -46,20 +46,3 @@
       (reset! artifacts/artifacts {"org.clojure/clojure" clojure-versions})
       (is (= sorted-clojure-versions
              (artifacts/artifact-versions {:artifact "org.clojure/clojure"}))))))
-
-(deftest hotload-dependency-throws-exceptions
-  (reset! artifacts/artifacts {"prismatic/schema" ["0.1"]})
-  (with-redefs
-    [artifacts/make-resolve-missing-aware-of-new-deps (fn [& _])
-     artifacts/stale-cache? (constantly false)
-     artifacts/distill (constantly true)]
-    (testing "Throws for non existing version"
-      (is (thrown? IllegalArgumentException
-                   (artifacts/hotload-dependency
-                    {:coordinates "[prismatic/schema \"1.0\"]"}))))
-    (testing "Throws for non existing artifact"
-      (is (thrown? IllegalArgumentException
-                   (artifacts/hotload-dependency
-                    {:coordinates "[imaginary \"1.0\"]"}))))
-    (testing "No exception when all is OK"
-      (is (artifacts/hotload-dependency {:coordinates "[prismatic/schema \"0.1\"]"})))))