CLJS-3371: Invalid warning on record constructor (#168)

Record constructor has a second arity that accept 2 additionnal parameters

Co-authored-by: Roland THIOLLIERE <[email protected]>

Author: swannodette

src/main/clojure/cljs/analyzer.cljc

@@ -2554,7 +2554,10 @@
          known-num-fields (:num-fields ctor-var)
          argc (count args)]
      (when (and (not (-> ctor meta :internal-ctor))
-                (some? known-num-fields) (not= known-num-fields argc))
+                (some? known-num-fields)
+                (not (or (= known-num-fields argc)
+                         (and (:record ctor-var)
+                              (= (+ 2 known-num-fields) argc)))))
        (warning :fn-arity env {:argc argc :ctor ctor}))
      {:env env :op :new :form form :class ctorexpr :args argexprs
       :children [:class :args]

src/test/clojure/cljs/analyzer_tests.clj

@@ -1492,3 +1492,23 @@
         '[(ns test.foo
             (:import goog))]))
     (is (= {} (get-in @cenv [::ana/namespaces 'test.foo :imports])))))
+
+(deftest test-cljs-3371
+  (let [ws (atom [])]
+    (ana/with-warning-handlers [(collecting-warning-handler ws)]
+      (env/with-compiler-env @test-cenv
+        (analyze (ana/empty-env)
+                 '(do
+                    (defrecord Foo [a])
+                    (Foo. nil)
+                    (Foo. nil nil nil)))))
+    (is (empty? @ws)))
+  (let [ws (atom [])]
+    (ana/with-warning-handlers [(collecting-warning-handler ws)]
+      (env/with-compiler-env @test-cenv
+        (analyze (ana/empty-env)
+                 '(do
+                    (defrecord Foo [a])
+                    (Foo. nil nil)))))
+    (is (= 1 (count @ws)))
+    (is (string/starts-with? (first @ws) "Wrong number of args (2) passed to Foo"))))