Skip to content

Commit 8f7a156

Browse files
committed
cleanup compilation reporting, do not reporting compilation unless
actually compiling.
1 parent 6292633 commit 8f7a156

File tree

2 files changed

+26
-26
lines changed

2 files changed

+26
-26
lines changed

src/main/clojure/cljs/closure.clj

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -892,15 +892,13 @@
892892
(if (every? #(not (contains? input-set' %)) requires)
893893
(do
894894
(try
895-
(util/measure (and compiler-stats verbose)
896-
(str "Compile " (:ns ns-info))
897-
(swap! compiled conj
898-
(-compile (or (:source-file ns-info)
899-
(:source-forms ns-info))
900-
; - ns-info -> ns -> cljs file relpath -> js relpath
901-
(merge opts
902-
{:output-file (comp/rename-to-js
903-
(util/ns->relpath (:ns ns-info)))}))))
895+
(swap! compiled conj
896+
(-compile (or (:source-file ns-info)
897+
(:source-forms ns-info))
898+
; - ns-info -> ns -> cljs file relpath -> js relpath
899+
(merge opts
900+
{:output-file (comp/rename-to-js
901+
(util/ns->relpath (:ns ns-info)))})))
904902
(catch Throwable e
905903
(reset! failed e)))
906904
(when-not @failed
@@ -945,12 +943,10 @@
945943
(for [ns-info inputs]
946944
; TODO: compile-file calls parse-ns unnecessarily to get ns-info
947945
; TODO: we could mark dependent namespaces for recompile here
948-
(util/measure (and compiler-stats (:verbose opts))
949-
(str "Compile " (:ns ns-info))
950-
(-compile (or (:source-file ns-info)
951-
(:source-forms ns-info))
952-
; - ns-info -> ns -> cljs file relpath -> js relpath
953-
(merge opts {:output-file (comp/rename-to-js (util/ns->relpath (:ns ns-info)))}))))))))))
946+
(-compile (or (:source-file ns-info)
947+
(:source-forms ns-info))
948+
; - ns-info -> ns -> cljs file relpath -> js relpath
949+
(merge opts {:output-file (comp/rename-to-js (util/ns->relpath (:ns ns-info)))})))))))))
954950

955951
(defn add-goog-base
956952
[inputs]

src/main/clojure/cljs/compiler.cljc

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1405,18 +1405,22 @@
14051405
(ensure
14061406
(with-core-cljs opts
14071407
(fn []
1408-
(when (or ana/*verbose* (:verbose opts))
1408+
(when (and (or ana/*verbose* (:verbose opts))
1409+
(not (:compiler-stats opts)))
14091410
(util/debug-prn "Compiling" (str src)))
1410-
(let [ext (util/ext src)
1411-
{:keys [ns] :as ns-info} (ana/parse-ns src)]
1412-
(if-let [cached (cached-core ns ext opts)]
1413-
(emit-cached-core src dest cached opts)
1414-
(let [opts (if (macro-ns? ns ext opts)
1415-
(assoc opts :macros-ns true)
1416-
opts)
1417-
ret (emit-source src dest ext opts)]
1418-
(.setLastModified ^File dest (util/last-modified src))
1419-
ret)))))))))
1411+
(util/measure (and (or ana/*verbose* (:verbose opts))
1412+
(:compiler-stats opts))
1413+
(str "Compiling " src)
1414+
(let [ext (util/ext src)
1415+
{:keys [ns] :as ns-info} (ana/parse-ns src)]
1416+
(if-let [cached (cached-core ns ext opts)]
1417+
(emit-cached-core src dest cached opts)
1418+
(let [opts (if (macro-ns? ns ext opts)
1419+
(assoc opts :macros-ns true)
1420+
opts)
1421+
ret (emit-source src dest ext opts)]
1422+
(.setLastModified ^File dest (util/last-modified src))
1423+
ret))))))))))
14201424

14211425
#?(:clj
14221426
(defn requires-compilation?

0 commit comments

Comments
 (0)