Skip to content

Commit 9c4f2ef

Browse files
committed
- remove straggling ObjMap stuff
- cleanup ObjMap tests, either comment out, or remove things which will no longer be relevant (promotion to PHM)
1 parent 45e34d2 commit 9c4f2ef

File tree

3 files changed

+4
-27
lines changed

3 files changed

+4
-27
lines changed

src/main/cljs/cljs/core.cljs

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -9034,19 +9034,6 @@ reduces them without incurring seq initialization"
90349034
(.createAsIfByAssoc PersistentArrayMap (to-array s))
90359035
(if (seq s) (first s) (.-EMPTY PersistentArrayMap))))
90369036

9037-
(defn obj-map
9038-
"keyval => key val
9039-
Returns a new object map with supplied mappings."
9040-
[& keyvals]
9041-
(let [ks (array)
9042-
obj (js-obj)]
9043-
(loop [kvs (seq keyvals)]
9044-
(if kvs
9045-
(do (.push ks (first kvs))
9046-
(gobject/set obj (first kvs) (second kvs))
9047-
(recur (nnext kvs)))
9048-
(.fromObject ObjMap ks obj)))))
9049-
90509037
(defn sorted-map
90519038
"keyval => key val
90529039
Returns a new sorted map with supplied mappings."
@@ -10698,10 +10685,6 @@ reduces them without incurring seq initialization"
1069810685
MapEntry
1069910686
(-pr-writer [coll writer opts] (pr-sequential-writer writer pr-writer "[" " " "]" opts coll))
1070010687

10701-
ObjMap
10702-
(-pr-writer [coll writer opts]
10703-
(print-map coll pr-writer writer opts))
10704-
1070510688
KeySeq
1070610689
(-pr-writer [coll writer opts] (pr-sequential-writer writer pr-writer "(" " " ")" opts coll))
1070710690

src/test/cljs/cljs/collections_test.cljs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
(is (= {:a :b} (get {[1 2 3] {:a :b}, 4 5} [1 2 3])))
2222
(is (not (= {:a :b :c nil} {:a :b :d nil})))
2323
(is (= {:a :b} (dissoc {:a :b :c :d} :c)))
24-
(is (= (hash-map :foo 5)
25-
(assoc (cljs.core.ObjMap. nil (array) (js-obj)) :foo 5))))
24+
#_(is (= (hash-map :foo 5)
25+
(assoc (ObjMap. nil (array) (js-obj)) :foo 5))))
2626
(testing "Testing assoc dissoc"
2727
(is (= {1 2 3 4} (assoc {} 1 2 3 4)))
2828
(is (= {1 2} (assoc {} 1 2)))
@@ -879,12 +879,6 @@
879879

880880
(deftest test-461
881881
;; CLJS-461: automatic map conversions
882-
(loop [i 0 m (with-meta {} {:foo :bar}) result []]
883-
(if (<= i (+ cljs.core.ObjMap.HASHMAP_THRESHOLD 2))
884-
(recur (inc i) (assoc m (str i) i) (conj result (meta m)))
885-
(let [n (inc (+ cljs.core.ObjMap.HASHMAP_THRESHOLD 2))
886-
expected (repeat n {:foo :bar})]
887-
(is (= result expected)))))
888882
(loop [i 0 m (with-meta {-1 :quux} {:foo :bar}) result []]
889883
(if (<= i (+ cljs.core.PersistentArrayMap.HASHMAP_THRESHOLD 2))
890884
(recur (inc i) (assoc m i i) (conj result (meta m)))

src/test/cljs/cljs/core_test.cljs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,9 @@
196196
(is (= #{:cljs.core-test/rect :cljs.core-test/square} (descendants ::shape)))
197197
(is (true? (isa? 42 42)))
198198
(is (true? (isa? ::square ::shape)))
199-
(derive cljs.core.ObjMap ::collection)
199+
;(derive ObjMap ::collection)
200200
(derive cljs.core.PersistentHashSet ::collection)
201-
(is (true? (isa? cljs.core.ObjMap ::collection)))
201+
;(is (true? (isa? ObjMap ::collection)))
202202
(is (true? (isa? cljs.core.PersistentHashSet ::collection)))
203203
(is (false? (isa? cljs.core.IndexedSeq ::collection)))
204204
;; ?? (isa? String Object)

0 commit comments

Comments
 (0)