Skip to content

Commit b17c186

Browse files
anmonteiroswannodette
authored andcommitted
CLJS-2290: Node packages using require('assert') fail compilation
1 parent 10fcec6 commit b17c186

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/main/cljs/cljs/module_deps.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var md = mdeps({
1818
resolver(id, parent, cb);
1919
},
2020
filter: function(id) {
21-
return !nodeResolve.isCore(id);
21+
return !(target === 'nodejs' && nodeResolve.isCore(id));
2222
},
2323
detect: function(src) {
2424
var deps = konan(src);

src/test/clojure/cljs/closure_tests.clj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,8 @@
185185
(test/delete-node-modules)
186186
(spit (io/file "package.json") "{}")
187187
(test/delete-out-files out)
188-
(let [opts {:npm-deps {:node-fetch "1.7.1"}}]
188+
(let [opts {:npm-deps {:node-fetch "1.7.1"}
189+
:target :nodejs}]
189190
(closure/maybe-install-node-deps! opts)
190191
(is (true? (some (fn [module]
191192
(= module {:module-type :es6

0 commit comments

Comments
 (0)