Skip to content

Commit 1cc0779

Browse files
committed
Correctly run commented out tests
1 parent 06ae1b3 commit 1cc0779

File tree

1 file changed

+46
-48
lines changed

1 file changed

+46
-48
lines changed

.github/workflows/test-all-the-things.yml

Lines changed: 46 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -189,14 +189,14 @@ jobs:
189189
subjectRepo: 'michaelklishin/chash'
190190
subjectRef: 'master'
191191

192-
# FAILS on Java 8
193-
# test-money:
194-
# uses: ./.github/workflows/lein-test.yml
195-
# with:
196-
# clojureRepo: ${{ inputs.clojureRepo }}
197-
# clojureRef: ${{ inputs.clojureRef }}
198-
# subjectRepo: 'clojurewerkz/money'
199-
# subjectRef: 'main'
192+
test-money:
193+
uses: ./.github/workflows/lein-test.yml
194+
with:
195+
clojureRepo: ${{ inputs.clojureRepo }}
196+
clojureRef: ${{ inputs.clojureRef }}
197+
subjectRepo: 'clojurewerkz/money'
198+
subjectRef: 'main'
199+
javaVersion: '["11", "17", "21"]'
200200

201201
test-propertied:
202202
uses: ./.github/workflows/lein-test.yml
@@ -255,14 +255,14 @@ jobs:
255255
subjectRepo: 'michaelklishin/validateur'
256256
subjectRef: 'master'
257257

258-
# FAILS on java 21
259-
# test-cheshire:
260-
# uses: ./.github/workflows/lein-test.yml
261-
# with:
262-
# clojureRepo: ${{ inputs.clojureRepo }}
263-
# clojureRef: ${{ inputs.clojureRef }}
264-
# subjectRepo: 'dakrone/cheshire'
265-
# subjectRef: 'master'
258+
test-cheshire:
259+
uses: ./.github/workflows/lein-test.yml
260+
with:
261+
clojureRepo: ${{ inputs.clojureRepo }}
262+
clojureRef: ${{ inputs.clojureRef }}
263+
subjectRepo: 'dakrone/cheshire'
264+
subjectRef: 'master'
265+
javaVersion: '["8", "11", "17"]'
266266

267267
test-tigris:
268268
uses: ./.github/workflows/lein-test.yml
@@ -560,14 +560,14 @@ jobs:
560560
subjectRepo: 'redplanetlabs/vector-backed-sorted-map'
561561
subjectRef: 'main'
562562

563-
# Fails on Java 8
564-
# test-ring-core:
565-
# uses: ./.github/workflows/lein-test.yml
566-
# with:
567-
# clojureRepo: ${{ inputs.clojureRepo }}
568-
# clojureRef: ${{ inputs.clojureRef }}
569-
# subjectRepo: 'ring-clojure/ring'
570-
# subjectRef: 'master'
563+
test-ring-core:
564+
uses: ./.github/workflows/lein-test.yml
565+
with:
566+
clojureRepo: ${{ inputs.clojureRepo }}
567+
clojureRef: ${{ inputs.clojureRef }}
568+
subjectRepo: 'ring-clojure/ring'
569+
subjectRef: 'master'
570+
javaVersion: '["11", "17", "21"]'
571571

572572
test-ring-anti-forgery:
573573
uses: ./.github/workflows/lein-test.yml
@@ -960,14 +960,13 @@ jobs:
960960
# subjectRepo: 'finagle/finagle-clojure'
961961
# subjectRef: 'master'
962962

963-
# Repo not downloading
964-
# test-incomplete:
965-
# uses: ./.github/workflows/lein-test.yml
966-
# with:
967-
# clojureRepo: ${{ inputs.clojureRepo }}
968-
# clojureRef: ${{ inputs.clojureRef }}
969-
# subjectRepo: 'nrepl/incomplete'
970-
# subjectRef: 'main'
963+
test-incomplete:
964+
uses: ./.github/workflows/lein-test.yml
965+
with:
966+
clojureRepo: ${{ inputs.clojureRepo }}
967+
clojureRef: ${{ inputs.clojureRef }}
968+
subjectRepo: 'nrepl/incomplete'
969+
subjectRef: 'main'
971970

972971
# Requires prep phase to run
973972
# test-pedestal:
@@ -988,14 +987,14 @@ jobs:
988987
subjectRepo: 'alexanderkiel/async-error'
989988
subjectRef: 'master'
990989

991-
# Maven build uses release flag, not supported for Java 8
992-
# test-fressian:
993-
# uses: ./.github/workflows/mvn-test.yml
994-
# with:
995-
# clojureRepo: ${{ inputs.clojureRepo }}
996-
# clojureRef: ${{ inputs.clojureRef }}
997-
# subjectRepo: 'Datomic/fressian'
998-
# subjectRef: 'master'
990+
test-fressian:
991+
uses: ./.github/workflows/mvn-test.yml
992+
with:
993+
clojureRepo: ${{ inputs.clojureRepo }}
994+
clojureRef: ${{ inputs.clojureRef }}
995+
subjectRepo: 'Datomic/fressian'
996+
subjectRef: 'master'
997+
javaVersion: '["11", "17", "21"]'
999998

1000999
test-slingshot:
10011000
uses: ./.github/workflows/lein-test.yml
@@ -1023,14 +1022,13 @@ jobs:
10231022
# subjectRepo: 'clj-commons/manifold'
10241023
# subjectRef: 'master'
10251024

1026-
# Checkouts fail
1027-
# test-pandect:
1028-
# uses: ./.github/workflows/lein-test.yml
1029-
# with:
1030-
# clojureRepo: ${{ inputs.clojureRepo }}
1031-
# clojureRef: ${{ inputs.clojureRef }}
1032-
# subjectRepo: 'xsc/pandect'
1033-
# subjectRef: 'main'
1025+
test-pandect:
1026+
uses: ./.github/workflows/lein-test.yml
1027+
with:
1028+
clojureRepo: ${{ inputs.clojureRepo }}
1029+
clojureRef: ${{ inputs.clojureRef }}
1030+
subjectRepo: 'xsc/pandect'
1031+
subjectRef: 'main'
10341032

10351033
# Tests fail on at least Java 11 (need type hint for overloaded toArray)
10361034
# test-clj-jwt:

0 commit comments

Comments
 (0)