TNS-59: Adds a guard to the source file metadata creation for files that do not contain a ns decl nor a ns name.

Author: fogus

src/main/clojure/clojure/tools/namespace/find.clj

@@ -89,10 +89,11 @@
   ([dir] (find-ns-decls-in-dir dir nil))
   ([dir platform]
    (keep #(ignore-reader-exception
-           (let [[_ nom & more] (file/read-file-ns-decl % (:read-opts platform))]
-             (list* 'ns (with-meta nom
-                          {:dir (.getName ^java.io.File dir) :file (.getName ^java.io.File %)})
-                    more)))
+           (let [[_ nom & more :as decl] (file/read-file-ns-decl % (:read-opts platform))]
+             (when (and decl nom (symbol? nom))
+               (list* 'ns (with-meta nom
+                            {:dir (.getName ^java.io.File dir) :file (.getName ^java.io.File %)})
+                      more))))
          (find-sources-in-dir dir platform))))
 
 (defn find-namespaces-in-dir

src/test/clojure/clojure/tools/namespace/find_test.clj

@@ -33,7 +33,8 @@
         main-clj (help/create-source dir 'example.main :clj '[example.one])
         one-cljc (help/create-source dir 'example.one :cljc '[example.two])
         two-clj (help/create-source dir 'example.two :clj)
-        two-cljs (help/create-source dir 'example.two :cljs)]
+        two-cljs (help/create-source dir 'example.two :cljs)
+        headless-clj (help/create-headless-source dir 'example.headless :clj)]
     (is (every? #{(.getName ^java.io.File dir)}
          (map #(-> % second meta :dir)
               (find/find-ns-decls [dir]))))))

src/test/clojure/clojure/tools/namespace/test_helpers.clj

@@ -73,6 +73,22 @@
                    (list 'ns sym))]
      (create-file full-path (into [ns-decl] contents)))))
 
+(defn create-headless-source
+  "Creates a file at the correct path under base-dir for a file that
+  declares in-ns for namespace named sym, with file extension (keyword)
+  and will also require the dependencies (symbols). Optional contents
+  written after the ns declaration as by write-contents."
+  ([base-dir sym extension]
+   (create-headless-source base-dir sym extension nil nil))
+  ([base-dir sym extension dependencies]
+   (create-headless-source base-dir sym extension dependencies nil))
+  ([base-dir sym extension dependencies contents]
+   (let [full-path (into [base-dir] (source-path sym extension))
+         ins-decl (list 'in-ns (list 'quote sym))
+         deps-decl (when (seq dependencies)
+                     (map #(list 'require `(quote ~%)) dependencies))]
+     (create-file full-path (filter identity (concat [ins-decl] deps-decl contents))))))
+
 (defn same-files?
   "True if files-a and files-b contain the same canonical File's,
   regardless of order."