Getting uncaught exception when passing invalid slack webhook URL

[fizerkhan]

When i set "null" as web hook URL, it throws following

error: UncaughtException: Thu, 11 Jun 2015 14:44:22 GMT
error: TypeError: Cannot read property 'statusCode' of undefined
(err):     at Request._callback (~/myserver/node_modules/slack-node/lib/lib/slack.seed.js:63:25)

The code breaks when body object is undefined, Can you add a check before accessing statusCode.

Thanks

[kevinburkeshyp]

might be confused but what's the use case for setting null as the hook URL?

[fizerkhan]

@kevinburkeshyp In our use case, we set our client slack URL(which might be null) in redis. The redis returns string "null" when getting the slack url. Here we have to manually check for not equal to string "null".

Previously, i did not check the "null" value, so it crashed my server. It is better to check for valid slack URL in this library.

[fizerkhan]

@kevinburke this error happens even for invalid URL. Can you add a check before accessing statusCode?

[kevinburkeshyp]

Sorry, I'm still a little confused by this. as far as I can tell if the webhook URL is null, nothing is sent anywhere, the request lib just errors because it can't resolve the host. It seems like it would be preferable to avoid sending the request to this library in the first place?

[fizerkhan]

@kevinburkeshyp i can handle null URL in my end. But this error also happens when there is a invalid URL.

Can you please add small check before accessing statusCode? We really don't want any uncaught exceptions which crashes entire app. You can pass the error in the callback.