for library usage of tfrunner Make plan=False work. (#73)

Co-authored-by: Kapil Thangavelu <[email protected]>

Author: howbazaar

pytest_terraform/tf.py

@@ -64,11 +64,11 @@ def __init__(
 
     def apply(self, plan=True):
         """run terraform apply"""
-        if plan is True:
+        if plan:
             plan_path = os.path.join(self.work_dir, "tfplan")
             self.plan(plan_path)
             apply_args = self._get_cmd_args("apply", plan=plan_path)
-        elif plan:
+        else:
             apply_args = self._get_cmd_args("apply", plan="")
         try:
             self._run_cmd(apply_args)

tests/test_terraform.py

@@ -151,7 +151,8 @@ def test_tf_statejson_update_bad():
 
 
 @pytest.mark.skipif(not shutil.which("terraform"), reason="Terraform binary missing")
-def test_tf_runner(testdir, tmpdir):
+@pytest.mark.parametrize("plan", (True, False))
+def test_tf_runner(testdir, tmpdir, plan):
     # ** requires network access to install plugin **
     with open(tmpdir.join("resources.tf"), "w") as fh:
         fh.write(
@@ -165,7 +166,7 @@ def test_tf_runner(testdir, tmpdir):
 
     trunner = tf.TerraformRunner(tmpdir.strpath, tf_bin=shutil.which("terraform"))
     trunner.init()
-    state = trunner.apply()
+    state = trunner.apply(plan=plan)
     assert state.get("foo")["content"] == "foo!"
     with open(tmpdir.join("foo.bar")) as fh:
         assert fh.read() == "foo!"