remove log.Fatal and return error to avoid early program termination (#403)

markdboyd · web-flow · commit 0d48b6c0f14c · 2025-03-12T15:49:38.000Z
diff --git a/cmd/tasks/tags/tags.go b/cmd/tasks/tags/tags.go
@@ -1,7 +1,7 @@
 package tags
 
 import (
-	"log"
+	"fmt"
 
 	brokertags "github.com/cloud-gov/go-broker-tags"
 )
@@ -15,7 +15,7 @@ func GenerateTags(tagManager brokertags.TagManager, serviceOfferingName string,
 		true,
 	)
 	if err != nil {
-		log.Fatalf("error generating new tags for database %s", err)
+		return map[string]string{}, fmt.Errorf("error generating new tags for database %s", err)
 	}
 	// We can ignore the timestamp tags, if they exist
 	delete(generatedTags, "Created at")

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`package tags`
`2`	`2`
`3`	`3`	`import (`
`4`		`- "log"`
	`4`	`+ "fmt"`
`5`	`5`
`6`	`6`	`brokertags "github.com/cloud-gov/go-broker-tags"`
`7`	`7`	`)`
`@@ -15,7 +15,7 @@ func GenerateTags(tagManager brokertags.TagManager, serviceOfferingName string,`
`15`	`15`	`true,`
`16`	`16`	`)`
`17`	`17`	`if err != nil {`
`18`		`- log.Fatalf("error generating new tags for database %s", err)`
	`18`	`+ return map[string]string{}, fmt.Errorf("error generating new tags for database %s", err)`
`19`	`19`	`}`
`20`	`20`	`// We can ignore the timestamp tags, if they exist`
`21`	`21`	`delete(generatedTags, "Created at")`