Add notify_inval_inode and extend get_rootfs to return fs_idx for umount #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidneychang
requested review from
bergwolf,
imeoer,
liubogithub and
eryugey
as code owners
sidneychang
force-pushed
the
notify-inval-inode-and-get-rootfs-fsidx
branch
2 times, most recently
from
c093957 to
a25fdc0
Compare
…ount - Add notify_inval_inode method to fusedev to explicitly invalidate inode caches in the kernel, ensuring cache coherence when backend files change outside guest VFS. - Extend get_rootfs to return both Arc<BackFileSystem> and u8 fs_idx. This is necessary for correct unmount handling and cache invalidation. The implementation follows fuse kernel and libfuse protocols and maintains compatibility with existing patterns like notify_inval_entry. Signed-off-by: sidneychang <[email protected]>
sidneychang
force-pushed
the
notify-inval-inode-and-get-rootfs-fsidx
branch
from
a25fdc0 to
a29fec8
Compare
imeoer
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two related improvements to better support multi-filesystem
mounting scenarios on fuse, especially during unmount operations:
Add
notify_inval_inodesupport in fusedev, enabling user space toexplicitly notify the kernel to invalidate inode page caches. This helps
clear caches properly after unmounting.
Extend the VFS method
get_rootfsto return both the mounted backendfilesystem (Arc) and its associated filesystem index
(fs_idx). Although multi-filesystem mounting is already supported,
returning fs_idx is necessary for proper unmount handling and cache
invalidation.
The implementation follows fuse kernel and libfuse protocols and maintains
compatibility with existing patterns like notify_inval_entry.