ch: Add domain validation function for vcpu info

Once hotplug support is available we need to be able to validate the
information read from the system matches our expectations. In this
case, we check that thread ids for cpus exist if and only if a cpu is
online.

Author: bryteise

src/ch/ch_domain.c

@@ -416,6 +416,47 @@ char *virCHDomainGetMachineName(virDomainObjPtr vm)
     return ret;
 }
 
+/**
+ * virCHDomainValidateVcpuInfo:
+ *
+ * Validates vcpu thread information. If vcpu thread IDs are available,
+ * this function validates that online vcpus have thread info present and
+ * offline vcpus don't.
+ *
+ * Returns 0 on success -1 on error.
+ */
+int
+virCHDomainValidateVcpuInfo(virDomainObjPtr vm)
+{
+    size_t maxvcpus = virDomainDefGetVcpusMax(vm->def);
+    virDomainVcpuDefPtr vcpu;
+    virCHDomainVcpuPrivatePtr vcpupriv;
+    size_t i;
+
+    if (!virCHDomainHasVcpuPids(vm))
+        return 0;
+
+    for (i = 0; i < maxvcpus; i++) {
+        vcpu = virDomainDefGetVcpu(vm->def, i);
+        vcpupriv = CH_DOMAIN_VCPU_PRIVATE(vcpu);
+
+        if (vcpu->online && vcpupriv->tid == 0) {
+            virReportError(VIR_ERR_INTERNAL_ERROR,
+                           _("Didn't find thread id for vcpu '%zu'"), i);
+            return -1;
+        }
+
+        if (!vcpu->online && vcpupriv->tid != 0) {
+            virReportError(VIR_ERR_INTERNAL_ERROR,
+                           _("Found thread id for inactive vcpu '%zu'"),
+                           i);
+            return -1;
+        }
+    }
+
+    return 0;
+}
+
 /**
  * virCHDomainObjFromDomain:
  * @domain: Domain pointer that has to be looked up

src/ch/ch_domain.h

@@ -127,6 +127,10 @@ pid_t virCHDomainGetVcpuPid(virDomainObjPtr vm, unsigned int vcpuid);
 bool virCHDomainHasVcpuPids(virDomainObjPtr vm);
 
 char *virCHDomainGetMachineName(virDomainObjPtr vm);
+
+int
+virCHDomainValidateVcpuInfo(virDomainObjPtr vm);
+
 virDomainObjPtr virCHDomainObjFromDomain(virDomainPtr domain);
 
 int