ch: Validate device type for serial/console

When creating the vm configuration options passed to cloud-hypervisor,
look at the source->type and ensure it is a PTY before trying to use
that device.

Similarly when trying to open a console ensure the source->type is
also a PTY.

This is done as the vm->def for console may be populated with content
that isn't valid for cloud-hypervisor usage. The preferred vm
definition should contain the following:

<console type='pty'>
  <target type='serial' port='0'/>
</console>

for serial console and

<console type='pty'>
  <target type='virtio' port='0'/>
</console>

for virtio console (with only one defined regardless of type).

Author: bryteise

src/ch/ch_driver.c

@@ -865,7 +865,8 @@ chDomainOpenConsole(virDomainPtr dom,
                 chr = vm->def->parallels[i];
         }
     } else {
-        if (vm->def->nconsoles)
+        if (vm->def->nconsoles &&
+            vm->def->consoles[0]->source->type == VIR_DOMAIN_CHR_TYPE_PTY)
             chr = vm->def->consoles[0];
         else if (vm->def->nserials)
             chr = vm->def->serials[0];

src/ch/ch_monitor.c

@@ -114,27 +114,33 @@ virCHMonitorBuildPTYJson(virJSONValuePtr content, virDomainDefPtr vmdef)
     virJSONValuePtr ptys = virJSONValueNewObject();
 
     if (vmdef->nconsoles || vmdef->nserials) {
-        if (vmdef->nconsoles > 1) {
+        if ((vmdef->nconsoles &&
+             vmdef->consoles[0]->source->type == VIR_DOMAIN_CHR_TYPE_PTY)
+            && (vmdef->nserials &&
+                vmdef->serials[0]->source->type == VIR_DOMAIN_CHR_TYPE_PTY)) {
+            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                           _("Only a single console or serial can be configured for this domain"));
+            return -1;
+        } else if (vmdef->nconsoles > 1) {
             virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                            _("Only a single console can be configured for this domain"));
             return -1;
-        }
-        if (vmdef->nserials > 1) {
+        } else if (vmdef->nserials > 1) {
             virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                            _("Only a single serial can be configured for this domain"));
             return -1;
         }
     }
 
-    if (vmdef->nconsoles) {
+    if (vmdef->nconsoles && vmdef->consoles[0]->source->type == VIR_DOMAIN_CHR_TYPE_PTY) {
         if (virJSONValueObjectAppendString(ptyc, "mode", "Pty") < 0)
             goto cleanup;
     } else {
         if (virJSONValueObjectAppendString(ptyc, "mode", "Null") < 0)
             goto cleanup;
     }
 
-    if (vmdef->nserials) {
+    if (vmdef->nserials && vmdef->serials[0]->source->type == VIR_DOMAIN_CHR_TYPE_PTY) {
         if (virJSONValueObjectAppendString(ptys, "mode", "Pty") < 0)
             goto cleanup;
     } else {