Skip to content

Commit 0823bae

Browse files
committed
Merge branch 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
Pull i2c fixes from Wolfram Sang: "Two bugfixes for the I2C subsystem" * 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux: i2c: mpc: Poll for MCF misc: eeprom: at24: Always append device id even if label property is set.
2 parents bca1d4d + 4a8ac5e commit 0823bae

File tree

2 files changed

+9
-12
lines changed

2 files changed

+9
-12
lines changed

drivers/i2c/busses/i2c-mpc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -635,8 +635,8 @@ static irqreturn_t mpc_i2c_isr(int irq, void *dev_id)
635635

636636
status = readb(i2c->base + MPC_I2C_SR);
637637
if (status & CSR_MIF) {
638-
/* Read again to allow register to stabilise */
639-
status = readb(i2c->base + MPC_I2C_SR);
638+
/* Wait up to 100us for transfer to properly complete */
639+
readb_poll_timeout(i2c->base + MPC_I2C_SR, status, !(status & CSR_MCF), 0, 100);
640640
writeb(0, i2c->base + MPC_I2C_SR);
641641
mpc_i2c_do_intr(i2c, status);
642642
return IRQ_HANDLED;

drivers/misc/eeprom/at24.c

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -714,23 +714,20 @@ static int at24_probe(struct i2c_client *client)
714714
}
715715

716716
/*
717-
* If the 'label' property is not present for the AT24 EEPROM,
718-
* then nvmem_config.id is initialised to NVMEM_DEVID_AUTO,
719-
* and this will append the 'devid' to the name of the NVMEM
720-
* device. This is purely legacy and the AT24 driver has always
721-
* defaulted to this. However, if the 'label' property is
722-
* present then this means that the name is specified by the
723-
* firmware and this name should be used verbatim and so it is
724-
* not necessary to append the 'devid'.
717+
* We initialize nvmem_config.id to NVMEM_DEVID_AUTO even if the
718+
* label property is set as some platform can have multiple eeproms
719+
* with same label and we can not register each of those with same
720+
* label. Failing to register those eeproms trigger cascade failure
721+
* on such platform.
725722
*/
723+
nvmem_config.id = NVMEM_DEVID_AUTO;
724+
726725
if (device_property_present(dev, "label")) {
727-
nvmem_config.id = NVMEM_DEVID_NONE;
728726
err = device_property_read_string(dev, "label",
729727
&nvmem_config.name);
730728
if (err)
731729
return err;
732730
} else {
733-
nvmem_config.id = NVMEM_DEVID_AUTO;
734731
nvmem_config.name = dev_name(dev);
735732
}
736733

0 commit comments

Comments
 (0)