xtensa: xtfpga: Fix refcount leak bug in setup

windhl · jcmvbkbc · commit 173940b3ae40 · 2022-06-18T14:47:41.000-07:00
In machine_setup(), of_find_compatible_node() will return a node
pointer with refcount incremented. We should use of_node_put() when
it is not used anymore.

Cc: stable@vger.kernel.org
Signed-off-by: Liang He &lt;windhl@126.com&gt;
Message-Id: &lt;20220617115323.4046905-1-windhl@126.com&gt;
Signed-off-by: Max Filippov &lt;jcmvbkbc@gmail.com&gt;
diff --git a/arch/xtensa/platforms/xtfpga/setup.c b/arch/xtensa/platforms/xtfpga/setup.c
@@ -133,6 +133,7 @@ static int __init machine_setup(void)
 
 	if ((eth = of_find_compatible_node(eth, NULL, "opencores,ethoc")))
 		update_local_mac(eth);
+	of_node_put(eth);
 	return 0;
 }
 arch_initcall(machine_setup);

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,7 @@ static int __init machine_setup(void)`
`133`	`133`
`134`	`134`	`if ((eth = of_find_compatible_node(eth, NULL, "opencores,ethoc")))`
`135`	`135`	`update_local_mac(eth);`
	`136`	`+ of_node_put(eth);`
`136`	`137`	`return 0;`
`137`	`138`	`}`
`138`	`139`	`arch_initcall(machine_setup);`