Skip to content

Commit 1872910

Browse files
LiHuiSong1rafaeljw
authored andcommitted
ACPI: PCC: Fix Tx acknowledge in the PCC address space handler
Currently, mbox_client_txdone() is called from the PCC address space handler and that expects the user the Tx state machine to be controlled by the client which is not the case and the below warning is thrown: | PCCT: Client can't run the TX ticker Let the controller run the state machine and the end of Tx can be acknowledge by calling mbox_chan_txdone() instead. Fixes: 77e2a04 ("ACPI: PCC: Implement OperationRegion handler for the PCC Type 3 subtype") Signed-off-by: Huisong Li <[email protected]> Reviewed-by: Sudeep Holla <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 91cefef commit 1872910

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/acpi/acpi_pcc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ acpi_pcc_address_space_handler(u32 function, acpi_physical_address addr,
121121
}
122122
}
123123

124-
mbox_client_txdone(data->pcc_chan->mchan, ret);
124+
mbox_chan_txdone(data->pcc_chan->mchan, ret);
125125

126126
memcpy_fromio(value, data->pcc_comm_addr, data->ctx.length);
127127

0 commit comments

Comments
 (0)