gpio: mockup: remove gpio debugfs when remove device

Wei Yongjun · brgl · commit 303e6da99429 · 2022-08-28T15:58:48.000+02:00
GPIO mockup debugfs is created in gpio_mockup_probe() but
forgot to remove when remove device. This patch add a devm
managed callback for removing them.

Signed-off-by: Wei Yongjun &lt;weiyongjun1@huawei.com&gt;
Signed-off-by: Bartosz Golaszewski &lt;brgl@bgdev.pl&gt;
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
@@ -373,6 +373,13 @@ static void gpio_mockup_debugfs_setup(struct device *dev,
 	}
 }
 
+static void gpio_mockup_debugfs_cleanup(void *data)
+{
+	struct gpio_mockup_chip *chip = data;
+
+	debugfs_remove_recursive(chip->dbg_dir);
+}
+
 static void gpio_mockup_dispose_mappings(void *data)
 {
 	struct gpio_mockup_chip *chip = data;
@@ -455,7 +462,7 @@ static int gpio_mockup_probe(struct platform_device *pdev)
 
 	gpio_mockup_debugfs_setup(dev, chip);
 
-	return 0;
+	return devm_add_action_or_reset(dev, gpio_mockup_debugfs_cleanup, chip);
 }
 
 static const struct of_device_id gpio_mockup_of_match[] = {

Original file line number	Diff line number	Diff line change
`@@ -373,6 +373,13 @@ static void gpio_mockup_debugfs_setup(struct device *dev,`
`373`	`373`	`}`
`374`	`374`	`}`
`375`	`375`
	`376`	`+static void gpio_mockup_debugfs_cleanup(void *data)`
	`377`	`+{`
	`378`	`+ struct gpio_mockup_chip *chip = data;`
	`379`	`+`
	`380`	`+ debugfs_remove_recursive(chip->dbg_dir);`
	`381`	`+}`
	`382`	`+`
`376`	`383`	`static void gpio_mockup_dispose_mappings(void *data)`
`377`	`384`	`{`
`378`	`385`	`struct gpio_mockup_chip *chip = data;`
`@@ -455,7 +462,7 @@ static int gpio_mockup_probe(struct platform_device *pdev)`
`455`	`462`
`456`	`463`	`gpio_mockup_debugfs_setup(dev, chip);`
`457`	`464`
`458`		`- return 0;`
	`465`	`+ return devm_add_action_or_reset(dev, gpio_mockup_debugfs_cleanup, chip);`
`459`	`466`	`}`
`460`	`467`
`461`	`468`	`static const struct of_device_id gpio_mockup_of_match[] = {`