Skip to content

Commit 3168010

Browse files
nfrapradojoergroedel
authored andcommitted
iommu/mediatek: Log with dev_err_probe when failing to parse dts
mtk_iommu_mm_dts_parse() can fail with EPROBE_DEFER if not all larbs have probed yet, so use dev_err_probe() to avoid logging as an error in that case. Also drop the return value from the message since it's already printed by dev_err_probe(), and add the missing newline at the end. Signed-off-by: Nícolas F. R. A. Prado <[email protected]> Reviewed-by: AngeloGioacchino Del Regno <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Joerg Roedel <[email protected]>
1 parent 301c3ca commit 3168010

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/iommu/mtk_iommu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1216,7 +1216,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
12161216
if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM)) {
12171217
ret = mtk_iommu_mm_dts_parse(dev, &match, data);
12181218
if (ret) {
1219-
dev_err(dev, "mm dts parse fail(%d).", ret);
1219+
dev_err_probe(dev, ret, "mm dts parse fail\n");
12201220
goto out_runtime_disable;
12211221
}
12221222
} else if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_INFRA)) {

0 commit comments

Comments
 (0)