video: backlight: ili9320: Make ili9320_remove() return void

Uwe Kleine-König · Lee Jones · commit 3976e974df1f · 2021-10-20T15:13:59.000+01:00
Up to now ili9320_remove() returns zero unconditionally. Make it return void instead which makes it easier to see in the callers that there is no error to handle. Also the return value of spi remove callbacks is ignored anyway. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Lee Jones <lee.jones@linaro.org> Link: https://lore.kernel.org/r/20211019120927.3822792-1-u.kleine-koenig@pengutronix.de
diff --git a/drivers/video/backlight/ili9320.c b/drivers/video/backlight/ili9320.c
@@ -251,10 +251,9 @@ int ili9320_probe_spi(struct spi_device *spi,
 }
 EXPORT_SYMBOL_GPL(ili9320_probe_spi);
 
-int ili9320_remove(struct ili9320 *ili)
+void ili9320_remove(struct ili9320 *ili)
 {
 	ili9320_power(ili, FB_BLANK_POWERDOWN);
-	return 0;
 }
 EXPORT_SYMBOL_GPL(ili9320_remove);
 
diff --git a/drivers/video/backlight/ili9320.h b/drivers/video/backlight/ili9320.h
@@ -68,7 +68,7 @@ extern int ili9320_write_regs(struct ili9320 *ili,
 extern int ili9320_probe_spi(struct spi_device *spi,
 			     struct ili9320_client *cli);
 
-extern int ili9320_remove(struct ili9320 *lcd);
+extern void ili9320_remove(struct ili9320 *lcd);
 extern void ili9320_shutdown(struct ili9320 *lcd);
 
 /* PM */
diff --git a/drivers/video/backlight/vgg2432a4.c b/drivers/video/backlight/vgg2432a4.c
@@ -235,7 +235,9 @@ static int vgg2432a4_probe(struct spi_device *spi)
 
 static int vgg2432a4_remove(struct spi_device *spi)
 {
-	return ili9320_remove(spi_get_drvdata(spi));
+	ili9320_remove(spi_get_drvdata(spi));
+
+	return 0;
 }
 
 static void vgg2432a4_shutdown(struct spi_device *spi)

Original file line number	Diff line number	Diff line change
`@@ -251,10 +251,9 @@ int ili9320_probe_spi(struct spi_device *spi,`
`251`	`251`	`}`
`252`	`252`	`EXPORT_SYMBOL_GPL(ili9320_probe_spi);`
`253`	`253`
`254`		`-int ili9320_remove(struct ili9320 *ili)`
	`254`	`+void ili9320_remove(struct ili9320 *ili)`
`255`	`255`	`{`
`256`	`256`	`ili9320_power(ili, FB_BLANK_POWERDOWN);`
`257`		`- return 0;`
`258`	`257`	`}`
`259`	`258`	`EXPORT_SYMBOL_GPL(ili9320_remove);`
`260`	`259`
Original file line number	Diff line number	Diff line change
`@@ -235,7 +235,9 @@ static int vgg2432a4_probe(struct spi_device *spi)`
`235`	`235`
`236`	`236`	`static int vgg2432a4_remove(struct spi_device *spi)`
`237`	`237`	`{`
`238`		`- return ili9320_remove(spi_get_drvdata(spi));`
	`238`	`+ ili9320_remove(spi_get_drvdata(spi));`
	`239`	`+`
	`240`	`+ return 0;`
`239`	`241`	`}`
`240`	`242`
`241`	`243`	`static void vgg2432a4_shutdown(struct spi_device *spi)`