Skip to content

Commit 424e7d8

Browse files
committed
Merge tag 'efi-urgent-for-v5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull EFI fixes from Borislav Petkov: "Forwarded from Ard Biesheuvel through the tip tree. Ard will send stuff directly in the near future. Low priority fixes but fixes nonetheless: - update stub diagnostic print that is no longer accurate - avoid statically allocated buffer for CPER error record decoding - avoid sleeping on the efi_runtime semaphore when calling the ResetSystem EFI runtime service" * tag 'efi-urgent-for-v5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: efi: Change down_interruptible() in virt_efi_reset_system() to down_trylock() efi/cper: use stack buffer for error record decoding efi/libstub: Simplify "Exiting bootservices" message
2 parents 89f6602 + 38fa320 commit 424e7d8

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

drivers/firmware/efi/cper.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
#include <acpi/ghes.h>
2626
#include <ras/ras_event.h>
2727

28-
static char rcd_decode_str[CPER_REC_LEN];
29-
3028
/*
3129
* CPER record ID need to be unique even after reboot, because record
3230
* ID is used as index for ERST storage, while CPER records from
@@ -312,6 +310,7 @@ const char *cper_mem_err_unpack(struct trace_seq *p,
312310
struct cper_mem_err_compact *cmem)
313311
{
314312
const char *ret = trace_seq_buffer_ptr(p);
313+
char rcd_decode_str[CPER_REC_LEN];
315314

316315
if (cper_mem_err_location(cmem, rcd_decode_str))
317316
trace_seq_printf(p, "%s", rcd_decode_str);
@@ -326,6 +325,7 @@ static void cper_print_mem(const char *pfx, const struct cper_sec_mem_err *mem,
326325
int len)
327326
{
328327
struct cper_mem_err_compact cmem;
328+
char rcd_decode_str[CPER_REC_LEN];
329329

330330
/* Don't trust UEFI 2.1/2.2 structure with bad validation bits */
331331
if (len == sizeof(struct cper_sec_mem_err_old) &&

drivers/firmware/efi/libstub/fdt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ efi_status_t allocate_new_fdt_and_exit_boot(void *handle,
271271
return status;
272272
}
273273

274-
efi_info("Exiting boot services and installing virtual address map...\n");
274+
efi_info("Exiting boot services...\n");
275275

276276
map.map = &memory_map;
277277
status = efi_allocate_pages(MAX_FDT_SIZE, new_fdt_addr, ULONG_MAX);

drivers/firmware/efi/runtime-wrappers.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ static void virt_efi_reset_system(int reset_type,
414414
unsigned long data_size,
415415
efi_char16_t *data)
416416
{
417-
if (down_interruptible(&efi_runtime_lock)) {
417+
if (down_trylock(&efi_runtime_lock)) {
418418
pr_warn("failed to invoke the reset_system() runtime service:\n"
419419
"could not get exclusive access to the firmware\n");
420420
return;

0 commit comments

Comments
 (0)