io_uring: don't use TIF_NOTIFY_SIGNAL to test for availability of task_work

axboe · axboe · commit 6434ec0186b8 · 2022-12-17T13:40:17.000-07:00
Use task_work_pending() as a better test for whether we have task_work
or not, TIF_NOTIFY_SIGNAL is only valid if the any of the task_work
items had been queued with TWA_SIGNAL as the notification mechanism.
Hence task_work_pending() is a more reliable check.

Signed-off-by: Jens Axboe &lt;axboe@kernel.dk&gt;
diff --git a/io_uring/io_uring.h b/io_uring/io_uring.h
@@ -266,8 +266,7 @@ static inline int io_run_task_work(void)
 
 static inline bool io_task_work_pending(struct io_ring_ctx *ctx)
 {
-	return test_thread_flag(TIF_NOTIFY_SIGNAL) ||
-		!wq_list_empty(&ctx->work_llist);
+	return task_work_pending(current) || !wq_list_empty(&ctx->work_llist);
 }
 
 static inline int io_run_task_work_ctx(struct io_ring_ctx *ctx)

Original file line number	Diff line number	Diff line change
`@@ -266,8 +266,7 @@ static inline int io_run_task_work(void)`
`266`	`266`
`267`	`267`	`static inline bool io_task_work_pending(struct io_ring_ctx *ctx)`
`268`	`268`	`{`
`269`		`- return test_thread_flag(TIF_NOTIFY_SIGNAL) \|\|`
`270`		`- !wq_list_empty(&ctx->work_llist);`
	`269`	`+ return task_work_pending(current) \|\| !wq_list_empty(&ctx->work_llist);`
`271`	`270`	`}`
`272`	`271`
`273`	`272`	`static inline int io_run_task_work_ctx(struct io_ring_ctx *ctx)`