bpf, s390: Fix potential memory leak about jit_data

seehearfeel · Vasily Gorbik · commit 686cb8b9f6b4 · 2021-10-04T09:49:10.000+02:00
Make sure to free jit_data through kfree() in the error path. Fixes: 1c8f9b9 ("bpf: s390: add JIT support for multi-function programs") Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> Acked-by: Ilya Leoshkevich <iii@linux.ibm.com> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c
@@ -1826,7 +1826,7 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *fp)
 	jit.addrs = kvcalloc(fp->len + 1, sizeof(*jit.addrs), GFP_KERNEL);
 	if (jit.addrs == NULL) {
 		fp = orig_fp;
-		goto out;
+		goto free_addrs;
 	}
 	/*
 	 * Three initial passes:

Original file line number	Diff line number	Diff line change
`@@ -1826,7 +1826,7 @@ struct bpf_prog bpf_int_jit_compile(struct bpf_prog fp)`
`1826`	`1826`	`jit.addrs = kvcalloc(fp->len + 1, sizeof(*jit.addrs), GFP_KERNEL);`
`1827`	`1827`	`if (jit.addrs == NULL) {`
`1828`	`1828`	`fp = orig_fp;`
`1829`		`- goto out;`
	`1829`	`+ goto free_addrs;`
`1830`	`1830`	`}`
`1831`	`1831`	`/*`
`1832`	`1832`	`* Three initial passes:`