Skip to content

Commit 7315275

Browse files
popcornmixgregkh
authored andcommitted
drm/vc4: hdmi: Avoid log spam for audio start failure
[ Upstream commit b4e5646 ] We regularly get dmesg error reports of: [ 18.184066] hdmi-audio-codec hdmi-audio-codec.3.auto: ASoC: error at snd_soc_dai_startup on i2s-hifi: -19 [ 18.184098] MAI: soc_pcm_open() failed (-19) These are generated for any disconnected hdmi interface when pulseaudio attempts to open the associated ALSA device (numerous times). Each open generates a kernel error message, generating general log spam. The error messages all come from _soc_pcm_ret in sound/soc/soc-pcm.c#L39 which suggests returning ENOTSUPP, rather that ENODEV will be quiet. And indeed it is. Signed-off-by: Dom Cobley <[email protected]> Reviewed-by: Maxime Ripard <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Dave Stevenson <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent 74bee87 commit 7315275

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/vc4/vc4_hdmi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1924,7 +1924,7 @@ static int vc4_hdmi_audio_startup(struct device *dev, void *data)
19241924
}
19251925

19261926
if (!vc4_hdmi_audio_can_stream(vc4_hdmi)) {
1927-
ret = -ENODEV;
1927+
ret = -ENOTSUPP;
19281928
goto out_dev_exit;
19291929
}
19301930

0 commit comments

Comments
 (0)