drivers/net/bonding/bond_3ad: return when there's no aggregator

d-tatianin · davem330 · commit 9c807965483f · 2023-01-03T09:17:12.000Z
Otherwise we would dereference a NULL aggregator pointer when calling __set_agg_ports_ready on the line below. Found by Linux Verification Center (linuxtesting.org) with the SVACE static analysis tool. Fixes: 1da177e ("Linux-2.6.12-rc2") Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru> Reviewed-by: Jiri Pirko <jiri@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
@@ -1549,6 +1549,7 @@ static void ad_port_selection_logic(struct port *port, bool *update_slave_arr)
 			slave_err(bond->dev, port->slave->dev,
 				  "Port %d did not find a suitable aggregator\n",
 				  port->actor_port_number);
+			return;
 		}
 	}
 	/* if all aggregator's ports are READY_N == TRUE, set ready=TRUE

Original file line number	Diff line number	Diff line change
`@@ -1549,6 +1549,7 @@ static void ad_port_selection_logic(struct port port, bool update_slave_arr)`
`1549`	`1549`	`slave_err(bond->dev, port->slave->dev,`
`1550`	`1550`	`"Port %d did not find a suitable aggregator\n",`
`1551`	`1551`	`port->actor_port_number);`
	`1552`	`+ return;`
`1552`	`1553`	`}`
`1553`	`1554`	`}`
`1554`	`1555`	`/* if all aggregator's ports are READY_N == TRUE, set ready=TRUE`