dm cache metadata: remove unnecessary variable in __dump_mapping

Guo Zhengkui · Mike Snitzer · commit d254c3699fdd · 2022-05-09T15:40:10.000-04:00
Fix the following coccicheck warning:

drivers/md/dm-cache-metadata.c:1512:5-6: Unneeded variable: "r".
Return "0" on line 1520.

Signed-off-by: Guo Zhengkui &lt;guozhengkui@vivo.com&gt;
Signed-off-by: Mike Snitzer &lt;snitzer@kernel.org&gt;
diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
@@ -1509,15 +1509,14 @@ int dm_cache_load_mappings(struct dm_cache_metadata *cmd,
 
 static int __dump_mapping(void *context, uint64_t cblock, void *leaf)
 {
-	int r = 0;
 	__le64 value;
 	dm_oblock_t oblock;
 	unsigned flags;
 
 	memcpy(&value, leaf, sizeof(value));
 	unpack_value(value, &oblock, &flags);
 
-	return r;
+	return 0;
 }
 
 static int __dump_mappings(struct dm_cache_metadata *cmd)

Original file line number	Diff line number	Diff line change
`@@ -1509,15 +1509,14 @@ int dm_cache_load_mappings(struct dm_cache_metadata *cmd,`
`1509`	`1509`
`1510`	`1510`	`static int __dump_mapping(void context, uint64_t cblock, void leaf)`
`1511`	`1511`	`{`
`1512`		`- int r = 0;`
`1513`	`1512`	`__le64 value;`
`1514`	`1513`	`dm_oblock_t oblock;`
`1515`	`1514`	`unsigned flags;`
`1516`	`1515`
`1517`	`1516`	`memcpy(&value, leaf, sizeof(value));`
`1518`	`1517`	`unpack_value(value, &oblock, &flags);`
`1519`	`1518`
`1520`		`- return r;`
	`1519`	`+ return 0;`
`1521`	`1520`	`}`
`1522`	`1521`
`1523`	`1522`	`static int __dump_mappings(struct dm_cache_metadata *cmd)`