Skip to content

Commit da13b33

Browse files
andy-shevrafaeljw
authored andcommitted
ACPI: LPSS: Replace loop with first entry retrieval
After the commit 6505e45 ("ACPI: LPSS: Use the helper acpi_dev_get_memory_resources()") the list is empty or contains only resource of IORESOURCE_MEM type. Hence, no need to check for the type, and since we break after the first found, no need to iterate over full list. That said, replace loop with first entry retrieval. Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 6e5cbe7 commit da13b33

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

drivers/acpi/acpi_lpss.c

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -656,16 +656,14 @@ static int acpi_lpss_create_device(struct acpi_device *adev,
656656
if (ret < 0)
657657
goto err_out;
658658

659-
list_for_each_entry(rentry, &resource_list, node)
660-
if (resource_type(rentry->res) == IORESOURCE_MEM) {
661-
if (dev_desc->prv_size_override)
662-
pdata->mmio_size = dev_desc->prv_size_override;
663-
else
664-
pdata->mmio_size = resource_size(rentry->res);
665-
pdata->mmio_base = ioremap(rentry->res->start,
666-
pdata->mmio_size);
667-
break;
668-
}
659+
rentry = list_first_entry_or_null(&resource_list, struct resource_entry, node);
660+
if (rentry) {
661+
if (dev_desc->prv_size_override)
662+
pdata->mmio_size = dev_desc->prv_size_override;
663+
else
664+
pdata->mmio_size = resource_size(rentry->res);
665+
pdata->mmio_base = ioremap(rentry->res->start, pdata->mmio_size);
666+
}
669667

670668
acpi_dev_free_resource_list(&resource_list);
671669

0 commit comments

Comments
 (0)