platform/x86: thinkpad_acpi: Fix thinklight LED brightness returning 255

jwrdegoede · jwrdegoede · commit eebf82012ddd · 2023-01-30T14:37:22.000+01:00
Reading the thinklight LED brightnes while the LED is on returns 255 (LED_FULL) but we advertise a max_brightness of 1, so this should be 1 (LED_ON). Fixes: db5e2a4 ("platform/x86: thinkpad_acpi: Fix max_brightness of thinklight") Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20230127235723.412864-1-hdegoede@redhat.com
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
@@ -5563,7 +5563,7 @@ static int light_sysfs_set(struct led_classdev *led_cdev,
 
 static enum led_brightness light_sysfs_get(struct led_classdev *led_cdev)
 {
-	return (light_get_status() == 1) ? LED_FULL : LED_OFF;
+	return (light_get_status() == 1) ? LED_ON : LED_OFF;
 }
 
 static struct tpacpi_led_classdev tpacpi_led_thinklight = {

Original file line number	Diff line number	Diff line change
`@@ -5563,7 +5563,7 @@ static int light_sysfs_set(struct led_classdev *led_cdev,`
`5563`	`5563`
`5564`	`5564`	`static enum led_brightness light_sysfs_get(struct led_classdev *led_cdev)`
`5565`	`5565`	`{`
`5566`		`- return (light_get_status() == 1) ? LED_FULL : LED_OFF;`
	`5566`	`+ return (light_get_status() == 1) ? LED_ON : LED_OFF;`
`5567`	`5567`	`}`
`5568`	`5568`
`5569`	`5569`	`static struct tpacpi_led_classdev tpacpi_led_thinklight = {`