Skip to content

Commit f4a2aad

Browse files
athira-rajeevacmel
authored andcommitted
perf tests powerpc: Fix branch stack sampling test to include sanity check for branch filter
Commit b55878c ("perf test: Add test for branch stack sampling") added test for branch stack sampling. There is a sanity check in the beginning to skip the test if the hardware doesn't support branch stack sampling. Snippet <<>> skip the test if the hardware doesn't support branch stack sampling perf record -b -o- -B true > /dev/null 2>&1 || exit 2 <<>> But the testcase also uses branch sample types: save_type, any. if any platform doesn't support the branch filters used in the test, the testcase will fail. In powerpc, currently mutliple branch filters are not supported and hence this test fails in powerpc. Fix the sanity check to look at the support for branch filters used in this test before proceeding with the test. Fixes: b55878c ("perf test: Add test for branch stack sampling") Reported-by: Disha Goel <[email protected]> Reviewed-by: Kajol Jain <[email protected]> Signed-off-by: Athira Jajeev <[email protected]> Cc: German Gomez <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: [email protected] Cc: Madhavan Srinivasan <[email protected]> Cc: Michael Ellerman <[email protected]> Cc: Nageswara R Sastry <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent 71c86cd commit f4a2aad

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

tools/perf/tests/shell/test_brstack.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ if ! [ -x "$(command -v cc)" ]; then
1212
fi
1313

1414
# skip the test if the hardware doesn't support branch stack sampling
15-
perf record -b -o- -B true > /dev/null 2>&1 || exit 2
15+
# and if the architecture doesn't support filter types: any,save_type,u
16+
perf record -b -o- -B --branch-filter any,save_type,u true > /dev/null 2>&1 || exit 2
1617

1718
TMPDIR=$(mktemp -d /tmp/__perf_test.program.XXXXX)
1819

0 commit comments

Comments
 (0)