@@ -44,17 +44,6 @@ for the future release. You can find the trees here:
4444- https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
4545- https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
4646
47- How do I indicate which tree (net vs. net-next) my patch should be in?
48- ----------------------------------------------------------------------
49- To help maintainers and CI bots you should explicitly mark which tree
50- your patch is targeting. Assuming that you use git, use the prefix
51- flag::
52-
53- git format-patch --subject-prefix='PATCH net-next' start..finish
54-
55- Use ``net `` instead of ``net-next `` (always lower case) in the above for
56- bug-fix ``net `` content.
57-
5847How often do changes from these trees make it to the mainline Linus tree?
5948-------------------------------------------------------------------------
6049To understand this, you need to know a bit of background information on
@@ -127,15 +116,6 @@ patch. Patches are indexed by the ``Message-ID`` header of the emails
127116which carried them so if you have trouble finding your patch append
128117the value of ``Message-ID `` to the URL above.
129118
130- How long before my patch is accepted?
131- -------------------------------------
132- Generally speaking, the patches get triaged quickly (in less than
133- 48h). But be patient, if your patch is active in patchwork (i.e. it's
134- listed on the project's patch list) the chances it was missed are close to zero.
135- Asking the maintainer for status updates on your
136- patch is a good way to ensure your patch is ignored or pushed to the
137- bottom of the priority list.
138-
139119Should I directly update patchwork state of my own patches?
140120-----------------------------------------------------------
141121It may be tempting to help the maintainers and update the state of your
@@ -145,37 +125,21 @@ it to the maintainer to figure out what is the most recent and current
145125version that should be applied. If there is any doubt, the maintainer
146126will reply and ask what should be done.
147127
148- How do I divide my work into patches ?
128+ How long before my patch is accepted ?
149129-------------------------------------
150-
151- Put yourself in the shoes of the reviewer. Each patch is read separately
152- and therefore should constitute a comprehensible step towards your stated
153- goal.
154-
155- Avoid sending series longer than 15 patches. Larger series takes longer
156- to review as reviewers will defer looking at it until they find a large
157- chunk of time. A small series can be reviewed in a short time, so Maintainers
158- just do it. As a result, a sequence of smaller series gets merged quicker and
159- with better review coverage. Re-posting large series also increases the mailing
160- list traffic.
130+ Generally speaking, the patches get triaged quickly (in less than
131+ 48h). But be patient, if your patch is active in patchwork (i.e. it's
132+ listed on the project's patch list) the chances it was missed are close to zero.
133+ Asking the maintainer for status updates on your
134+ patch is a good way to ensure your patch is ignored or pushed to the
135+ bottom of the priority list.
161136
162137I made changes to only a few patches in a patch series should I resend only those changed?
163138------------------------------------------------------------------------------------------
164139No, please resend the entire patch series and make sure you do number your
165140patches such that it is clear this is the latest and greatest set of patches
166141that can be applied.
167142
168- I have received review feedback, when should I post a revised version of the patches?
169- -------------------------------------------------------------------------------------
170- Allow at least 24 hours to pass between postings. This will ensure reviewers
171- from all geographical locations have a chance to chime in. Do not wait
172- too long (weeks) between postings either as it will make it harder for reviewers
173- to recall all the context.
174-
175- Make sure you address all the feedback in your new posting. Do not post a new
176- version of the code if the discussion about the previous version is still
177- ongoing, unless directly instructed by a reviewer.
178-
179143I submitted multiple versions of a patch series and it looks like a version other than the last one has been accepted, what should I do?
180144----------------------------------------------------------------------------------------------------------------------------------------
181145There is no revert possible, once it is pushed out, it stays like that.
@@ -191,6 +155,82 @@ the case today. Please follow the standard stable rules in
191155:ref: `Documentation/process/stable-kernel-rules.rst <stable_kernel_rules >`,
192156and make sure you include appropriate Fixes tags!
193157
158+ I found a bug that might have possible security implications or similar. Should I mail the main netdev maintainer off-list?
159+ ---------------------------------------------------------------------------------------------------------------------------
160+ No. The current netdev maintainer has consistently requested that
161+ people use the mailing lists and not reach out directly. If you aren't
162+ OK with that, then perhaps consider mailing
[email protected] or
163+ reading about http://oss-security.openwall.org/wiki/mailing-lists/distros
164+ as possible alternative mechanisms.
165+
166+ How do I post corresponding changes to user space components?
167+ -------------------------------------------------------------
168+ User space code exercising kernel features should be posted
169+ alongside kernel patches. This gives reviewers a chance to see
170+ how any new interface is used and how well it works.
171+
172+ When user space tools reside in the kernel repo itself all changes
173+ should generally come as one series. If series becomes too large
174+ or the user space project is not reviewed on netdev include a link
175+ to a public repo where user space patches can be seen.
176+
177+ In case user space tooling lives in a separate repository but is
178+ reviewed on netdev (e.g. patches to ``iproute2 `` tools) kernel and
179+ user space patches should form separate series (threads) when posted
180+ to the mailing list, e.g.::
181+
182+ [PATCH net-next 0/3] net: some feature cover letter
183+ └─ [PATCH net-next 1/3] net: some feature prep
184+ └─ [PATCH net-next 2/3] net: some feature do it
185+ └─ [PATCH net-next 3/3] selftest: net: some feature
186+
187+ [PATCH iproute2-next] ip: add support for some feature
188+
189+ Posting as one thread is discouraged because it confuses patchwork
190+ (as of patchwork 2.2.2).
191+
192+ Any other tips to help ensure my net/net-next patch gets OK'd?
193+ --------------------------------------------------------------
194+ Attention to detail. Re-read your own work as if you were the
195+ reviewer. You can start with using ``checkpatch.pl ``, perhaps even with
196+ the ``--strict `` flag. But do not be mindlessly robotic in doing so.
197+ If your change is a bug fix, make sure your commit log indicates the
198+ end-user visible symptom, the underlying reason as to why it happens,
199+ and then if necessary, explain why the fix proposed is the best way to
200+ get things done. Don't mangle whitespace, and as is common, don't
201+ mis-indent function arguments that span multiple lines. If it is your
202+ first patch, mail it to yourself so you can test apply it to an
203+ unpatched tree to confirm infrastructure didn't mangle it.
204+
205+ Finally, go back and read
206+ :ref: `Documentation/process/submitting-patches.rst <submittingpatches >`
207+ to be sure you are not repeating some common mistake documented there.
208+
209+ How do I indicate which tree (net vs. net-next) my patch should be in?
210+ ----------------------------------------------------------------------
211+ To help maintainers and CI bots you should explicitly mark which tree
212+ your patch is targeting. Assuming that you use git, use the prefix
213+ flag::
214+
215+ git format-patch --subject-prefix='PATCH net-next' start..finish
216+
217+ Use ``net `` instead of ``net-next `` (always lower case) in the above for
218+ bug-fix ``net `` content.
219+
220+ How do I divide my work into patches?
221+ -------------------------------------
222+
223+ Put yourself in the shoes of the reviewer. Each patch is read separately
224+ and therefore should constitute a comprehensible step towards your stated
225+ goal.
226+
227+ Avoid sending series longer than 15 patches. Larger series takes longer
228+ to review as reviewers will defer looking at it until they find a large
229+ chunk of time. A small series can be reviewed in a short time, so Maintainers
230+ just do it. As a result, a sequence of smaller series gets merged quicker and
231+ with better review coverage. Re-posting large series also increases the mailing
232+ list traffic.
233+
194234Is the comment style convention different for the networking content?
195235---------------------------------------------------------------------
196236Yes, in a largely trivial way. Instead of this::
@@ -224,13 +264,16 @@ I am working in existing code which uses non-standard formatting. Which formatti
224264Make your code follow the most recent guidelines, so that eventually all code
225265in the domain of netdev is in the preferred format.
226266
227- I found a bug that might have possible security implications or similar. Should I mail the main netdev maintainer off-list?
228- ---------------------------------------------------------------------------------------------------------------------------
229- No. The current netdev maintainer has consistently requested that
230- people use the mailing lists and not reach out directly. If you aren't
231- OK with that, then perhaps consider mailing
[email protected] or
232- reading about http://oss-security.openwall.org/wiki/mailing-lists/distros
233- as possible alternative mechanisms.
267+ I have received review feedback, when should I post a revised version of the patches?
268+ -------------------------------------------------------------------------------------
269+ Allow at least 24 hours to pass between postings. This will ensure reviewers
270+ from all geographical locations have a chance to chime in. Do not wait
271+ too long (weeks) between postings either as it will make it harder for reviewers
272+ to recall all the context.
273+
274+ Make sure you address all the feedback in your new posting. Do not post a new
275+ version of the code if the discussion about the previous version is still
276+ ongoing, unless directly instructed by a reviewer.
234277
235278What level of testing is expected before I submit my change?
236279------------------------------------------------------------
@@ -244,32 +287,6 @@ and the patch series contains a set of kernel selftest for
244287You are expected to test your changes on top of the relevant networking
245288tree (``net `` or ``net-next ``) and not e.g. a stable tree or ``linux-next ``.
246289
247- How do I post corresponding changes to user space components?
248- -------------------------------------------------------------
249- User space code exercising kernel features should be posted
250- alongside kernel patches. This gives reviewers a chance to see
251- how any new interface is used and how well it works.
252-
253- When user space tools reside in the kernel repo itself all changes
254- should generally come as one series. If series becomes too large
255- or the user space project is not reviewed on netdev include a link
256- to a public repo where user space patches can be seen.
257-
258- In case user space tooling lives in a separate repository but is
259- reviewed on netdev (e.g. patches to ``iproute2 `` tools) kernel and
260- user space patches should form separate series (threads) when posted
261- to the mailing list, e.g.::
262-
263- [PATCH net-next 0/3] net: some feature cover letter
264- └─ [PATCH net-next 1/3] net: some feature prep
265- └─ [PATCH net-next 2/3] net: some feature do it
266- └─ [PATCH net-next 3/3] selftest: net: some feature
267-
268- [PATCH iproute2-next] ip: add support for some feature
269-
270- Posting as one thread is discouraged because it confuses patchwork
271- (as of patchwork 2.2.2).
272-
273290Can I reproduce the checks from patchwork on my local machine?
274291--------------------------------------------------------------
275292
@@ -303,23 +320,6 @@ it has a real, in-tree user. Mock-ups and tests based on ``netdevsim`` are
303320strongly encouraged when adding new APIs, but ``netdevsim `` in itself
304321is **not ** considered a use case/user.
305322
306- Any other tips to help ensure my net/net-next patch gets OK'd?
307- --------------------------------------------------------------
308- Attention to detail. Re-read your own work as if you were the
309- reviewer. You can start with using ``checkpatch.pl ``, perhaps even with
310- the ``--strict `` flag. But do not be mindlessly robotic in doing so.
311- If your change is a bug fix, make sure your commit log indicates the
312- end-user visible symptom, the underlying reason as to why it happens,
313- and then if necessary, explain why the fix proposed is the best way to
314- get things done. Don't mangle whitespace, and as is common, don't
315- mis-indent function arguments that span multiple lines. If it is your
316- first patch, mail it to yourself so you can test apply it to an
317- unpatched tree to confirm infrastructure didn't mangle it.
318-
319- Finally, go back and read
320- :ref: `Documentation/process/submitting-patches.rst <submittingpatches >`
321- to be sure you are not repeating some common mistake documented there.
322-
323323My company uses peer feedback in employee performance reviews. Can I ask netdev maintainers for feedback?
324324---------------------------------------------------------------------------------------------------------
325325
0 commit comments