ASoC: SDCA: Fix return value in sdca_regmap_mbq_size()

charleskeepax · gregkh · commit f6433733326b · 2025-09-25T11:16:51.000+02:00
[ Upstream commit f81e630 ] The MBQ size function returns an integer representing the size of a Control. Currently if the Control is not found the function will return false which makes little sense. Correct this typo to return -EINVAL. Fixes: e3f7caf ("ASoC: SDCA: Add generic regmap SDCA helpers") Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> Message-ID: <20250820163717.1095846-2-ckeepax@opensource.cirrus.com> Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/sound/soc/sdca/sdca_regmap.c b/sound/soc/sdca/sdca_regmap.c
@@ -196,7 +196,7 @@ int sdca_regmap_mbq_size(struct sdca_function_data *function, unsigned int reg)
 
 	control = function_find_control(function, reg);
 	if (!control)
-		return false;
+		return -EINVAL;
 
 	return clamp_val(control->nbits / BITS_PER_BYTE, sizeof(u8), sizeof(u32));
 }

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ int sdca_regmap_mbq_size(struct sdca_function_data *function, unsigned int reg)`
`196`	`196`
`197`	`197`	`control = function_find_control(function, reg);`
`198`	`198`	`if (!control)`
`199`		`- return false;`
	`199`	`+ return -EINVAL;`
`200`	`200`
`201`	`201`	`return clamp_val(control->nbits / BITS_PER_BYTE, sizeof(u8), sizeof(u32));`
`202`	`202`	`}`