Moves asset upload logic to after release is published (#109)

Author: Sean Sundberg

.github/workflows/notify.yaml

@@ -4,7 +4,6 @@ on:
   release:
     types:
       - published
-      - released
 
 jobs:
   notify:

.github/workflows/publish-assets.yaml

@@ -0,0 +1,76 @@
+name: Publish assets
+
+on:
+  release:
+    types:
+      - published
+
+jobs:
+  release-installer:
+    runs-on: ubuntu-latest
+
+    env:
+      DIST_DIR: ./dist
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+        with:
+          ref: ${{ github.event.release.tag_name }}
+
+      - name: Build tile installer
+        run: |
+          mkdir -p ${{ env.DIST_DIR }}
+          cat ./.tile/scripts/master.sh | sed "s/VERSION=latest/VERSION=${{ github.event.release.tag_name }}/g" > ${{ env.DIST_DIR }}/create-catalog-offering.sh
+          chmod +x ${{ env.DIST_DIR }}/create-catalog-offering.sh
+
+      - name: Upload tile installer
+        uses: actions/upload-release-asset@v1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          upload_url: ${{ github.event.release.upload_url }}
+          asset_path: ./dist/create-catalog-offering.sh
+          asset_name: create-catalog-offering.sh
+          asset_content_type: application/octet-stream
+
+  release-offerings:
+    runs-on: ubuntu-latest
+
+    env:
+      DIST_DIR: ./dist
+
+    strategy:
+      matrix:
+        offering:
+          - cloudnative-toolkit
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+        with:
+          ref: ${{ github.event.release.tag_name }}
+
+      - name: Build offering
+        run: |
+          ./.tile/scripts/build.sh ${{ env.DIST_DIR }} ${{ matrix.offering }} ${{ github.event.release.tag_name }}
+
+      - name: Upload offering json
+        uses: actions/upload-release-asset@v1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          upload_url: ${{ github.event.release.upload_url }}
+          asset_path: ./dist/offering-${{ matrix.offering }}.json
+          asset_name: offering-${{ matrix.offering }}.json
+          asset_content_type: application/json
+
+      - name: Upload offering tar
+        uses: actions/upload-release-asset@v1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          upload_url: ${{ github.event.release.upload_url }}
+          asset_path: ./dist/${{ matrix.offering }}.tar.gz
+          asset_name: ${{ matrix.offering }}.tar.gz
+          asset_content_type: application/gzip

.github/workflows/release.yaml

@@ -11,9 +11,6 @@ jobs:
   release:
     runs-on: ubuntu-latest
 
-    env:
-      DIST_DIR: ./dist
-
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
       # Drafts your next Release notes as Pull Requests are merged into "master"
@@ -24,50 +21,3 @@ jobs:
           config-name: release-drafter.yaml
         env:
           GITHUB_TOKEN: ${{ secrets.TOKEN }}
-
-      - name: Checkout
-        uses: actions/checkout@v2
-
-      - name: Build tile installer
-        run: |
-          mkdir -p ${{ env.DIST_DIR }}
-          cat ./.tile/scripts/master.sh | sed "s/VERSION=latest/VERSION=${{ steps.create-release.outputs.tag_name }}/g" > ${{ env.DIST_DIR }}/create-catalog-offering.sh
-          chmod +x ${{ env.DIST_DIR }}/create-catalog-offering.sh
-
-      - name: Upload tile installer
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          upload_url: ${{ steps.create-release.outputs.upload_url }}
-          asset_path: ./dist/create-catalog-offering.sh
-          asset_name: create-catalog-offering.sh
-          asset_content_type: application/octet-stream
-
-      - name: Build offering
-        run: |
-          ./.tile/scripts/build.sh ${{ env.DIST_DIR }} ${{ env.OFFERING }} ${{ steps.create-release.outputs.tag_name }}
-        env:
-          OFFERING: cloudnative-toolkit
-
-      - name: Upload offering json
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          OFFERING: cloudnative-toolkit
-        with:
-          upload_url: ${{ steps.create-release.outputs.upload_url }}
-          asset_path: ./dist/offering-${{ env.OFFERING }}.json
-          asset_name: offering-${{ env.OFFERING }}.json
-          asset_content_type: application/json
-
-      - name: Upload offering tar
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          OFFERING: cloudnative-toolkit
-        with:
-          upload_url: ${{ steps.create-release.outputs.upload_url }}
-          asset_path: ./dist/$${ env.OFFERING }}.tar.gz
-          asset_name: ${{ env.OFFERING }}.tar.gz
-          asset_content_type: application/gzip