Skip to content

Commit f2a5081

Browse files
author
Sean Sundberg
authored
Updates pipelines (#97)
* Updates notify pipeline logic to handle module version updates * Adds region as preferred value name but keeps vlan_region for backwards compatibility * Replaces direct references to cluster_type in stages with cluster.type_code * Adds destroy script * Bumps ibm container-platform to v1.11.0 to support `iks.*` for cluster_type
1 parent 21ee116 commit f2a5081

File tree

15 files changed

+59
-18
lines changed

15 files changed

+59
-18
lines changed

.github/scripts/update-modules.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ if [[ -n "$GITHUB_USERNAME" ]] && [[ -n "$GITHUB_TOKEN" ]]; then
77
GITHUB_AUTH="-u ${GITHUB_USERNAME}:${GITHUB_TOKEN}"
88
fi
99

10-
find "${REPO_DIR}/terraform/stages" -name "*.tf" -depth 1 | while read stageFile; do
10+
set -e
11+
12+
ls "${REPO_DIR}"/terraform/stages/*.tf | while read stageFile; do
1113
echo "Updating stage: $stageFile"
1214
SOURCES=$(grep -E 'source *=' "${stageFile}" | sed -E 's/.*source *= *"(.*)"/\1/g')
1315

docs/VLAN.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ To make getting this information as simple as possible we have added a command t
4242
public_vlan_number="1849"
4343
public_vlan_router_hostname="fcr01a.dal10"
4444
vlan_datacenter="dal10"
45-
vlan_region="us-south"
45+
region="us-south"
4646
resource_group_name="catalyst-team"
4747
cluster_name="catalyst-team-cluster"
4848
```

terraform/scripts/destroy.sh

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
#! /bin/bash
2+
3+
echo ""
4+
echo "Listing current state"
5+
terraform state list
6+
7+
echo ""
8+
echo "Collecting resources to destroy"
9+
RESOURCE_LIST=""
10+
while read -r resource; do
11+
echo " Adding $resource to destroy targets"
12+
RESOURCE_LIST="$RESOURCE_LIST -target=$resource"
13+
done < <(terraform state list)
14+
15+
if [[ -n "$RESOURCE_LIST" ]]; then
16+
echo ""
17+
echo "Planning destroy"
18+
terraform plan -destroy $RESOURCE_LIST -out=destroy.plan
19+
20+
echo ""
21+
echo "Destroying resources"
22+
terraform apply -auto-approve destroy.plan
23+
else
24+
echo ""
25+
echo "Nothing to destroy!!"
26+
fi

terraform/scripts/ibmcloud-cluster

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ if [[ -z "${RESOURCE_GROUP}" ]]; then
1616
exit 1
1717
fi
1818

19-
REGION="${vlan_region}"
19+
REGION="${region}"
2020
if [[ -z "${REGION}" ]]; then
21-
echo "vlan_region is required in environment.tfvars"
21+
echo "region is required in environment.tfvars"
2222
exit 1
2323
fi
2424

terraform/scripts/ibmcloud-login

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ if [[ -z "${RESOURCE_GROUP}" ]]; then
1515
exit 1
1616
fi
1717

18-
REGION="${vlan_region}"
18+
REGION="${region}"
1919
if [[ -z "${REGION}" ]]; then
20-
echo "vlan_region is required in environment.tfvars"
20+
echo "region is required in environment.tfvars"
2121
exit 1
2222
fi
2323

terraform/settings/environment.tfvars

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ vpc_cluster="false"
2121
cluster_name="<cluster name>"
2222

2323
resource_group_name="<resource group>"
24-
vlan_region="us-east"
24+
region="us-east"
2525

2626
# This flag is used to indicate that the LogDNA instance already exists. The default is "false"
2727
# if this value is not provided. If LogDNA is not installed this value is ignored

terraform/stages-crc/stage1-cluster.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module "dev_cluster" {
66
private_vlan_id = var.private_vlan_id
77
public_vlan_id = var.public_vlan_id
88
vlan_datacenter = var.vlan_datacenter
9-
cluster_region = var.vlan_region
9+
cluster_region = var.vlan_region != "" ? var.vlan_region : var.region
1010
kubeconfig_download_dir = var.user_home_dir
1111
cluster_machine_type = var.cluster_machine_type
1212
cluster_worker_count = var.cluster_worker_count

terraform/stages-crc/variables.tf

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,18 @@ variable "vlan_datacenter" {
3636
default = ""
3737
}
3838

39-
variable "vlan_region" {
39+
variable "region" {
4040
type = string
4141
description = "Region for VLANs defined in private_vlan_number and public_vlan_number."
4242
default = ""
4343
}
4444

45+
variable "vlan_region" {
46+
type = string
47+
description = "(Deprecated) Region for VLANs defined in private_vlan_number and public_vlan_number."
48+
default = ""
49+
}
50+
4551
# Cluster Variables
4652
variable "cluster_machine_type" {
4753
type = string

terraform/stages/catalog/stage1-cloud_operator.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module "dev_software_cloud_operator" {
22
source = "github.com/ibm-garage-cloud/garage-terraform-modules.git//self-managed/software/cloud_operator?ref=v2.2.0"
33

44
resource_group_name = var.resource_group_name
5-
resource_location = var.vlan_region
5+
resource_location = var.vlan_region != "" ? var.vlan_region : var.region
66
cluster_config_file = module.dev_cluster.config_file_path
77
ibmcloud_api_key = module.dev_cluster.ibmcloud_api_key
88
}

terraform/stages/catalog/stage3-postgres.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module "dev_infrastructure_postgres" {
22
source = "github.com/ibm-garage-cloud/garage-terraform-modules.git//cloud-managed/services/postgres?ref=v2.2.4"
33

44
resource_group_name = var.resource_group_name
5-
resource_location = var.vlan_region
5+
resource_location = var.region
66
server_exists = var.postgres_server_exists
77
cluster_id = module.dev_cluster.id
88
namespaces = concat([module.dev_cluster_namespaces.tools_namespace_name], module.dev_cluster_namespaces.release_namespaces)

0 commit comments

Comments
 (0)