Skip to content

Commit 47cce73

Browse files
authored
Update cortex and add support for multiple modules (#8)
* Update cortex and add support for multiple modules Add support for by explictely specifying a target in the servcies config. cortexproject/cortex#3275 Signed-off-by: Julien Pivotto <[email protected]>
1 parent 4fda2ae commit 47cce73

File tree

14 files changed

+66
-39
lines changed

14 files changed

+66
-39
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ cache: pip
88
services:
99
- docker
1010
env:
11-
- ANSIBLE=2.7
1211
- ANSIBLE=2.8
1312
- ANSIBLE=2.9
13+
- ANSIBLE=2.10
1414
install:
1515
- pip3 install tox-travis git-semver
1616
script:

.yamllint

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1+
---
12
extends: default
23
ignore: |
34
.travis/
45
.travis.yml
56
.github/
7+
.tox/
68
meta/
79

810
rules:

defaults/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
cortex_version: 1.4.0
2+
cortex_version: 1.5.0
33
cortex_all_in_one: true
44

55
cortex_web_listen_address: "0.0.0.0:9009"

molecule/alternative/molecule.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@ dependency:
33
name: galaxy
44
driver:
55
name: docker
6-
lint:
7-
name: yamllint
6+
lint: |
7+
set -e
8+
yamllint .
9+
ansible-lint
10+
flake8
811
platforms:
912
- name: bionic
1013
image: quay.io/paulfantom/molecule-systemd:ubuntu-18.04
@@ -69,6 +72,3 @@ scenario:
6972
name: alternative
7073
verifier:
7174
name: testinfra
72-
lint:
73-
name: flake8
74-
enabled: true

molecule/default/destroy.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,3 @@
2323
until: docker_jobs.finished
2424
retries: 300
2525
with_items: "{{ server.results }}"
26-
27-
- name: Delete docker network(s)
28-
docker_network:
29-
name: "{{ item }}"
30-
docker_host: "{{ item.docker_host | default('unix://var/run/docker.sock') }}"
31-
state: absent
32-
with_items: "{{ molecule_yml.platforms | molecule_get_docker_networks }}"

molecule/default/molecule.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@ dependency:
33
name: galaxy
44
driver:
55
name: docker
6-
lint:
7-
name: yamllint
6+
lint: |
7+
set -e
8+
yamllint .
9+
ansible-lint
10+
flake8
811
platforms:
912
- name: bionic
1013
image: quay.io/paulfantom/molecule-systemd:ubuntu-18.04
@@ -69,6 +72,3 @@ scenario:
6972
name: default
7073
verifier:
7174
name: testinfra
72-
lint:
73-
name: flake8
74-
enabled: true

molecule/latest/molecule.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@ dependency:
33
name: galaxy
44
driver:
55
name: docker
6-
lint:
7-
name: yamllint
6+
lint: |
7+
set -e
8+
yamllint .
9+
ansible-lint
10+
flake8
811
platforms:
912
- name: buster
1013
image: quay.io/paulfantom/molecule-systemd:debian-10
@@ -37,6 +40,3 @@ scenario:
3740
name: latest
3841
verifier:
3942
name: testinfra
40-
lint:
41-
name: flake8
42-
enabled: true

molecule/services/molecule.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@ dependency:
33
name: galaxy
44
driver:
55
name: docker
6-
lint:
7-
name: yamllint
6+
lint: |
7+
set -e
8+
yamllint .
9+
ansible-lint
10+
flake8
811
platforms:
912
- name: bionic
1013
image: quay.io/paulfantom/molecule-systemd:ubuntu-18.04
@@ -69,6 +72,3 @@ scenario:
6972
name: services
7073
verifier:
7174
name: testinfra
72-
lint:
73-
name: flake8
74-
enabled: true

molecule/services/playbook.yml

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,25 @@
2020
min_ready_duration: 0s
2121
final_sleep: 0s
2222
num_tokens: 512
23-
2423
ring:
2524
kvstore:
2625
store: inmemory
27-
replication_factor: 1
26+
storage:
27+
engine: blocks
28+
blocks_storage:
29+
backend: filesystem
30+
filesystem:
31+
dir: /tmp/blocks
32+
readpath:
33+
target: querier,store-gateway
34+
server:
35+
http_listen_port: 9010
36+
grpc_listen_port: 9096
37+
storage:
38+
engine: blocks
39+
querier:
40+
store_gateway_addresses: 127.0.0.1:9096
41+
blocks_storage:
42+
backend: filesystem
43+
filesystem:
44+
dir: /tmp/blocks

molecule/services/tests/test_services.py

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,19 @@ def test_service(host):
4747
assert s.is_running
4848

4949

50-
def test_socket(host):
51-
s = host.socket("tcp://0.0.0.0:9009")
50+
@pytest.mark.parametrize("port", [9009, 9010, 9095, 9096])
51+
def test_socket(host, port):
52+
s = host.socket("tcp://0.0.0.0:%d" % port)
5253
assert s.is_listening
54+
55+
56+
def test_config_file_no_target(host):
57+
f = host.file("/cortex/cortex-ingester.yml")
58+
config = yaml.load(f.content_string, Loader=yaml.SafeLoader)
59+
assert config["target"] == "ingester"
60+
61+
62+
def test_config_file_explicit_target(host):
63+
f = host.file("/cortex/cortex-readpath.yml")
64+
config = yaml.load(f.content_string, Loader=yaml.SafeLoader)
65+
assert config["target"] == "querier,store-gateway"

0 commit comments

Comments
 (0)