Skip to content
This repository was archived by the owner on Mar 6, 2023. It is now read-only.

Commit 5bc131e

Browse files
authored
Merge pull request #219 from cloudalchemy/skeleton
[REPO SYNC] Merge pull request #9 from cloudalchemy/superq/more_updates
2 parents cddc25f + caff997 commit 5bc131e

File tree

7 files changed

+22
-39
lines changed

7 files changed

+22
-39
lines changed

.circleci/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,13 @@ jobs:
3434
- run: molecule test -s default --destroy always
3535
- run: |
3636
if [[ -d 'molecule/alternative' ]]; then
37-
molecule test -s alternative --destroy never
37+
molecule test -s alternative --destroy always
3838
else
3939
echo 'No alternative test'
4040
fi
4141
- run: |
4242
if [[ -z "${CIRCLE_PULL_REQUEST}" ]] && [[ -d 'molecule/latest' ]]; then
43-
molecule test -s latest --destroy never
43+
molecule test -s latest --destroy always
4444
else
4545
echo 'Not running latest on PR'
4646
fi

.github/labeler.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,19 @@ area/docs:
44
- meta/*
55
- CHANGELOG.md
66
- CONTRIBUTING.md
7+
- TROUBLESHOOTING.md
78
- LICENSE
89
- README.md
910
area/tests:
1011
- molecule/*
1112
- molecule/**/*
1213
- .ansible-lint
14+
- .yamllint
1315
- test-requirements.txt
14-
- tox.ini
1516
area/automation:
16-
- .travis/*
17+
- .circleci/*
1718
- .github/*
1819
- .github/**/*
19-
- .travis.yml
2020
- .mergify.yml
2121
area/vars:
2222
- defaults/*

.mergify.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,7 @@ pull_request_rules:
1010
merge:
1111
method: squash
1212
strict: true
13+
- name: delete head branch after merge
14+
conditions: []
15+
actions:
16+
delete_head_branch: {}

.yamllint

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
---
22
extends: default
33
ignore: |
4-
.travis/
5-
.travis.yml
64
.github/
75
meta/
86

CONTRIBUTING.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,17 @@ Some great guidelines can be found [here](https://wiki.openstack.org/wiki/GitCom
3434
## Releases
3535

3636
We try to stick to semantic versioning and our releases are automated. Release is created by assigning a keyword (in a
37-
way similar to travis [`[ci skip]`](https://docs.travis-ci.com/user/customizing-the-build#Skipping-a-build)) to a
38-
commit with merge request. Available keywords are (square brackets are important!):
37+
way similar to circle ci keyword [`[ci skip]`](https://docs.travis-ci.com/user/customizing-the-build#Skipping-a-build))
38+
to a commit with merge request. Available keywords are (square brackets are important!):
3939

40-
* `[patch]`, `[fix]` - for PATCH version release
40+
* `[patch]`, `[fix]`, `[bugfix]` - for PATCH version release
4141
* `[minor]`, `[feature]`, `[feat]` - for MINOR version release
4242
* `[major]`, `[breaking change]` - for MAJOR version release
4343

4444
## Changelog
4545

46-
Changelog is generateg automatically on every merged Pull Request and all information is taken from github issues, PRs
47-
and labels.
46+
Changelog is generated automatically during release process and all information is taken from github issues, PRs and
47+
labels.
4848

4949
## Expectations
5050

@@ -78,8 +78,9 @@ More information about:
7878
Please follow [ansible best practices](http://docs.ansible.com/ansible/latest/playbooks_best_practices.html) and
7979
especially provide meaningful names to tasks and even comments where needed.
8080

81-
Our test framework automatically lints code with [`yamllint`](https://yamllint.readthedocs.io) and
82-
[`ansible-lint`](https://github.com/willthames/ansible-lint) programs so be sure to follow their rules.
81+
Our test framework automatically lints code with [`yamllint`](https://github.com/adrienverge/yamllint),
82+
[`ansible-lint`](https://github.com/willthames/ansible-lint), and [`flake8`](https://gitlab.com/pycqa/flake8) programs
83+
so be sure to follow their rules.
8384

8485
Remember: Code is generally read much more often than written.
8586

@@ -92,6 +93,6 @@ Wherever possible, please refrain from any other formats and stick to simple mar
9293
We are trying to create the best and most secure installation method for non-containerized prometheus stack components.
9394
To accomplish this all roles need to support:
9495

95-
- current and at least one previous ansible version (wherever possible we try to support 2 previous ansible versions)
96+
- current and at least one previous ansible version
9697
- systemd as the only available process manager
9798
- at least latest debian and CentOS distributions

README.md

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Deploy prometheus [node exporter](https://github.com/prometheus/node_exporter) u
1717

1818
## Requirements
1919

20-
- Ansible >= 2.9 (It might work on previous versions, but we cannot guarantee it)
20+
- Ansible >= 2.7 (It might work on previous versions, but we cannot guarantee it)
2121
- gnu-tar on Mac deployer host (`brew install gnu-tar`)
2222
- Passlib is required when using the basic authentication feature (`pip install passlib[bcrypt]`)
2323

@@ -85,26 +85,11 @@ We provide demo site for full monitoring solution based on prometheus and grafan
8585
8686
## Local Testing
8787
88-
The preferred way of locally testing the role is to use Docker and [molecule](https://github.com/metacloud/molecule) (v2.x). You will have to install Docker on your system. See "Get started" for a Docker package suitable for your system.
89-
We are using tox to simplify the process of testing on multiple ansible versions. To install tox execute:
90-
```sh
91-
pip3 install tox
92-
```
93-
To run tests on all ansible versions (WARNING: this can take some time)
94-
```sh
95-
tox
96-
```
97-
To run a custom molecule command on a custom environment with only default test scenario:
98-
```sh
99-
tox -e py35-ansible28 -- molecule test -s default
100-
```
101-
For more information about molecule go to their [docs](http://molecule.readthedocs.io/en/latest/).
102-
103-
If you would like to run tests on a remote docker host just specify `DOCKER_HOST` variable before running tox tests.
88+
The preferred way of locally testing the role is to use Docker and [molecule](https://github.com/ansible-community/molecule) (v3.x). You will have to install Docker on your system. See "Get started" for a Docker package suitable to for your system. Running your tests is as simple as executing `molecule test`.
10489

105-
## Travis CI
90+
## Continuous Intergation
10691

107-
Combining molecule and travis CI allows us to test how new PRs will behave when used with multiple ansible versions and multiple operating systems. This also allows creating test scenarios for different role configurations. As a result, we have a quite large test matrix which will take more time than local testing, so please be patient.
92+
Combining molecule and circle CI allows us to test how new PRs will behave when used with multiple ansible versions and multiple operating systems. This also allows use to create test scenarios for different role configurations. As a result we have a quite large test matrix which can take more time than local testing, so please be patient.
10893

10994
## Contributing
11095

molecule/default/molecule.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,6 @@ dependency:
33
name: galaxy
44
driver:
55
name: docker
6-
# lint: |
7-
# set -e
8-
# yamllint .
9-
# ansible-lint
10-
# flake8
116
platforms:
127
- name: bionic
138
pre_build_image: true

0 commit comments

Comments
 (0)