WIP test rolling upgrade of federation mirrored supervisors

Author: gomoripeti

deps/rabbitmq_ct_helpers/src/rabbit_ct_broker_helpers.erl

@@ -167,6 +167,7 @@
 
     enable_plugin/3,
     disable_plugin/3,
+    set_plugins/3,
 
     test_channel/0,
     test_writer/1,
@@ -2415,6 +2416,9 @@ enable_plugin(Config, Node, Plugin) ->
 disable_plugin(Config, Node, Plugin) ->
     plugin_action(Config, Node, [disable, Plugin]).
 
+set_plugins(Config, Node, PluginList) ->
+    plugin_action(Config, Node, [set | PluginList]).
+
 plugin_action(Config, Node, Args) ->
     NodeConfig = get_node_config(Config, Node),
     Nodename = ?config(nodename, NodeConfig),

deps/rabbitmq_exchange_federation/test/exchange_SUITE.erl

@@ -580,14 +580,14 @@ lookup_exchange_status(Config) ->
 
 child_id_format(Config) ->
   case rabbit_ct_helpers:is_mixed_versions() of
-    false ->
+    true ->
           [UpstreamNode,
            OldNodeA,
            NewNodeB,
            OldNodeC,
            NewNodeD] = rabbit_ct_broker_helpers:get_node_configs(
                          Config, nodename),
-          
+
           %% Create a cluster with the nodes running the old version of RabbitMQ in
           %% mixed-version testing.
           %%
@@ -603,7 +603,12 @@ child_id_format(Config) ->
           %% secondary umbrella, `NewNodeB' the primary copy, and so on.
           Config1 = rabbit_ct_broker_helpers:cluster_nodes(
                       Config, [OldNodeA, OldNodeC]),
-          
+
+          %% The old nodes get the "rabbitmq_exchange_federation" plugin enabled but that is not found
+          %% Let's switch to the old plugin name
+          [rabbit_ct_broker_helpers:set_plugins(Config, Node, ["rabbitmq_federation"])
+           || Node <- [OldNodeA, OldNodeC]],
+
           %% Prepare the whole federated exchange on that old cluster.
           UpstreamName = <<"fed_on_upgrade">>,
           rabbit_ct_broker_helpers:set_parameter(
@@ -637,9 +642,17 @@ child_id_format(Config) ->
           case Id of
               %% This is the format we expect everywhere.
               #exchange{name = #resource{name = XName}} ->
+                  ct:pal("first checking old nodes"),
                   %% Verify that the supervisors exist on all nodes.
                   lists:foreach(
                     fun(Node) ->
+                            ct:pal("fed on old node ~p", [Node]),
+
+                            rabbit_ct_broker_helpers:rpc(
+                                 Config1, Node,
+                                 supervisor, which_children,
+                                 [rabbit_federation_sup]),
+
                             ?assertMatch(
                                [{#exchange{name = #resource{name = XName}},
                                  _, _, _}],
@@ -656,14 +669,24 @@ child_id_format(Config) ->
                   %% After that, the supervisors run on the new code.
                   Config2 = rabbit_ct_broker_helpers:cluster_nodes(
                               Config1, OldNodeA, [NewNodeB, NewNodeD]),
+
+                  %% Re-enable rabbit_exchange_federation plugin on
+                  %% the new nodes. They got reset when joining the
+                  %% cluster
+                  [rabbit_ct_broker_helpers:set_plugins(Config, Node, ["rabbitmq_exchange_federation"])
+                   || Node <- [NewNodeB, NewNodeD]],
+
                   ok = rabbit_ct_broker_helpers:stop_broker(Config2, OldNodeA),
                   ok = rabbit_ct_broker_helpers:reset_node(Config1, OldNodeA),
                   ok = rabbit_ct_broker_helpers:stop_broker(Config2, OldNodeC),
                   ok = rabbit_ct_broker_helpers:reset_node(Config2, OldNodeC),
 
+
                   %% Verify that the supervisors still use the same IDs.
                   lists:foreach(
                     fun(Node) ->
+                            ct:pal("new node ~p", [Node]),
+                            
                             ?assertMatch(
                                [{#exchange{name = #resource{name = XName}},
                                  _, _, _}],
@@ -691,7 +714,7 @@ child_id_format(Config) ->
                 when is_list(List) ->
                   {skip, "Testcase skipped with the transiently changed ID format"}
           end;
-      true ->
+      false ->
           %% skip the test in mixed version mode
           {skip, "Should not run in mixed version environments"}
   end.