Fix constant token renewal in the absence of a cookie Max-Age (#427)

Co-authored-by: markus-doellinger <[email protected]>

Author: markusd

CHANGES.md

@@ -1,3 +1,7 @@
+# Unreleased
+- [FIXED] Stopped constant token auto renewal in the absence of a cookie
+  header Max-Age
+
 # 4.2.4 (2020-03-02)
 - [FIXED] Pinned Nano to version 8.1 to resolve issue with extending upstream
   TypeScript changes in Nano version 8.2.0.

lib/tokens/TokenManager.js

@@ -35,7 +35,7 @@ class TokenManager {
       let maxAgeSecs = cookie.parse(response.headers['set-cookie'][0])['Max-Age'] || defaultMaxAgeSecs;
       let delayMSecs = maxAgeSecs / 2 * 1000;
       debug(`Renewing token in ${delayMSecs} milliseconds.`);
-      setTimeout(this._autoRenew.bind(this), delayMSecs).unref();
+      setTimeout(this._autoRenew.bind(this, defaultMaxAgeSecs), delayMSecs).unref();
     }).catch((error) => {
       debug(`Failed to auto renew token - ${error}. Retrying in 60 seconds.`);
       setTimeout(this._autoRenew.bind(this), 60000).unref();

test/tokens/TokenManager.js

@@ -23,19 +23,28 @@ class TokenManagerRenewSuccess extends TokenManager {
   constructor() {
     super();
     this._getTokenCallCount = 0;
+    this._cookieHeader = 'Max-Age=1';
   }
 
   _getToken(callback) {
     this._getTokenCallCount += 1;
     setTimeout(() => {
-      callback(null, { headers: { 'set-cookie': [ 'Max-Age=1' ] } });
+      callback(null, { headers: { 'set-cookie': [ this._cookieHeader ] } });
     }, 100);
   }
 
   // mock successful token renewal
   get getTokenCallCount() {
     return this._getTokenCallCount;
   }
+
+  get cookieHeader() {
+    return this._cookieHeader;
+  }
+
+  set cookieHeader(cookieHeader) {
+    this._cookieHeader = cookieHeader;
+  }
 }
 
 class TokenManagerRenewFailure extends TokenManager {
@@ -90,6 +99,17 @@ describe('Token Manger', (done) => {
     }, 2000);
   });
 
+  it('correctly auto renews token in the absence of a cookie Max-Age', (done) => {
+    let t = new TokenManagerRenewSuccess();
+    t.cookieHeader = '';
+    t.startAutoRenew(2);
+    setTimeout(() => {
+      // one renew every 1 seconds
+      assert.equal(t.getTokenCallCount, 2);
+      done();
+    }, 2000);
+  });
+
   it('only makes one renewal request', (done) => {
     let t = new TokenManagerRenewSuccess();
     let renewalCount = 0;