Skip to content
This repository was archived by the owner on Mar 11, 2022. It is now read-only.

Commit 6062647

Browse files
ricellisricellis
authored
Template updates (#326)
* Updated issue and PR templates * Updated CONTRIBUTING information
1 parent d30f7f4 commit 6062647

File tree

3 files changed

+145
-37
lines changed

3 files changed

+145
-37
lines changed

‎.github/ISSUE_TEMPLATE.md‎

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,23 @@
1-
Please include the following information in your ticket.
1+
Please [read these guidelines](http://ibm.biz/cdt-issue-guide) before opening an issue.
22

3-
- Cloudant (nodejs-cloudant) version(s) that are affected by this issue.
4-
- Node version
5-
- A small code sample that demonstrates the issue.
3+
<!-- Issues will be CLOSED IMMEDIATELY if the following template is not completed. -->
4+
5+
## Bug Description
6+
7+
### 1. Steps to reproduce and the simplest code sample possible to demonstrate the issue
8+
<!--
9+
Outline the steps you take to make the problem happen.
10+
Provide the simplest code sample you can, in context, that reproduces the issue.
11+
-->
12+
13+
### 2. What you expected to happen
14+
15+
### 3. What actually happened
16+
17+
## Environment details
18+
<!--
19+
- Version(s) that are affected by this issue.
20+
> 2.0.2
21+
- Node.js version
22+
> 6.13.0
23+
-->

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 91 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,102 @@
1+
<!--
12
Thanks for your hard work, please ensure all items are complete before opening.
3+
-->
4+
## Checklist
25

3-
- [ ] Tick to sign-off your agreement to the [Developer Certificate of Origin (DCO) 1.1](https://github.com/cloudant/nodejs-cloudant/blob/master/DCO1.1.txt)
4-
- [ ] You have added tests for any code changes
5-
- [ ] You have updated the [CHANGES.md](https://github.com/cloudant/nodejs-cloudant/blob/master/CHANGES.md)
6-
- [ ] You have completed the PR template below:
6+
- [ ] Tick to sign-off your agreement to the [Developer Certificate of Origin (DCO) 1.1](../blob/master/DCO1.1.txt)
7+
- [ ] Added tests for code changes _or_ test/build only changes
8+
- [ ] Updated the change log file (`CHANGES.md`|`CHANGELOG.md`) _or_ test/build only changes
9+
- [ ] Completed the PR template below:
710

8-
## What
11+
## Description
12+
<!--
13+
Provide a short description; saving the detail for the `Approach` section
914
10-
What was changed, e.g. Added support for querying views.
15+
Also EITHER:
16+
Link to issue this PR is resolving, use the Fixes #nnn form so that the
17+
issue closes automatically when the PR merges e.g.:
1118
12-
## How
19+
Fixes #23
1320
14-
How the change was implemented and reasoning behind it, e.g. Added create_index API to allow
15-
the creation of text and json indexes.
21+
OR
22+
23+
For PRs without an associated issue and/or test/build issues
24+
25+
### 1. Steps to reproduce and the simplest code sample possible to demonstrate the issue
26+
### 2. What you expected to happen
27+
### 3. What actually happened
28+
-->
29+
30+
## Approach
31+
32+
<!--
33+
Be brief: which component(s) of the code base does the fix focus on.
34+
35+
A place to note whether the part of the code base that is being worked is
36+
particularly sensitive.
37+
-->
38+
39+
## Schema & API Changes
40+
41+
<!--
42+
EITHER:
43+
44+
- "No change"
45+
46+
OR
47+
48+
For public API (as opposed to internal) changes
49+
50+
- "Fixing bug in API, will change x in such-and-such way"
51+
-->
52+
53+
## Security and Privacy
54+
55+
<!--
56+
EITHER:
57+
58+
- "No change"
59+
60+
OR
61+
62+
"Making changes in e.g. auth|https|encryption|io
63+
need to be careful about..."
64+
65+
-->
1666

1767
## Testing
1868

19-
How to test your changes work, not required for documentation changes.
69+
<!--
70+
EITHER:
71+
72+
- Added new tests:
73+
- test x
74+
- test y
75+
- test z
76+
77+
OR
78+
79+
- Modified existing tests because ...
80+
81+
OR
82+
83+
- N/A build or packaging only changes
84+
85+
OR
86+
87+
In exceptional circumstances there may be a good reason we can't add automated
88+
tests, for example if a specific device is required to reproduce a problem.
89+
90+
- No new tests because...
91+
-->
92+
93+
## Monitoring and Logging
94+
<!--
95+
EITHER:
96+
97+
- "No change"
2098
21-
## Issues
99+
OR
22100
23-
Links to the github issue(s) (if present) that this pull request is resolving.
101+
- "Added new log line X..."
102+
-->

‎CONTRIBUTING.md‎

Lines changed: 32 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,51 @@
1-
# Developer Certificate of Origin
1+
# Contributing
2+
3+
## Issues
4+
5+
Please [read these guidelines](http://ibm.biz/cdt-issue-guide) before opening an issue.
6+
If you still need to open an issue then we ask that you complete the template as
7+
fully as possible.
8+
9+
## Pull requests
10+
11+
We welcome pull requests, but ask contributors to keep in mind the following:
12+
13+
* Only PRs with the template completed will be accepted
14+
* We will not accept PRs for user specific functionality
15+
16+
### Developer Certificate of Origin
217

318
In order for us to accept pull-requests, the contributor must sign-off a
419
[Developer Certificate of Origin (DCO)](DCO1.1.txt). This clarifies the
520
intellectual property license granted with any contribution. It is for your
621
protection as a Contributor as well as the protection of IBM and its customers;
7-
it does not change your rights to use your own Contributions for any other
8-
purpose.
22+
it does not change your rights to use your own Contributions for any other purpose.
923

10-
Please read the agreement and acknowledge it by ticking the appropriate box in
11-
the PR text, for example:
24+
Please read the agreement and acknowledge it by ticking the appropriate box in the PR
25+
text, for example:
1226

1327
- [x] Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
1428

15-
# Contributing
29+
## General information
30+
31+
## Requirements
1632

17-
Everyone is welcome to contribute with patches, bug-fixes and new features.
33+
Node.js and npm, other dependencies will be installed automatically via `npm`
34+
and the `package.json` `dependencies` and `devDependencies`.
1835

19-
1. Create an [issue](http://github.com/cloudant/nodejs-cloudant/issues) on GitHub so the community can comment on your idea.
20-
2. Fork the repository in GitHub.
21-
3. Create a new branch `git checkout -b my_branch`.
22-
4. Create tests for the changes you made.
23-
5. Make sure you pass both existing and newly inserted tests.
24-
6. Commit your changes.
25-
7. Push to your branch `git push origin my_branch`.
26-
8. Create a pull request.
36+
## Testing
2737

28-
To run tests make sure you npm test but also run tests without mocks:
38+
To run tests:
2939

30-
``` sh
31-
npm run test-cloudant
40+
```sh
41+
npm test
3242
```
3343

44+
To run tests with a real, instead of mock, server then use the environment
45+
variable `NOCK_OFF=true`.
46+
3447
You can add verbose debug messages while running tests by doing:
3548

3649
```
37-
DEBUG=* node your_scripts.js
50+
DEBUG=* npm test
3851
```
39-
40-
You can turn nocks on and off using the `NOCK_OFF` environment variable.

0 commit comments

Comments
 (0)