Merge pull request #351 from cloudant/fix-request-ts-import

Use named import for `request.CoreOptions` type

Author: smithsz

.eslintignore

@@ -6,4 +6,5 @@ jsdoc/
 node_modules/
 templates/
 test/legacy/
+test/typescript/
 tmp/

CHANGES.md

@@ -1,3 +1,6 @@
+# UNRELEASED
+- [FIXED] Use named import for `request.CoreOptions` type.
+
 # 3.0.0 (2018-11-20)
 - [FIXED] Expose `BasePlugin` type in Cloudant client.
 - [FIXED] Set `parseUrl = false` on underlying Nano instance.

package.json

@@ -53,7 +53,7 @@
     "uuid": "^3.0.1"
   },
   "scripts": {
-    "test": "eslint --ignore-path .eslintignore . && mocha && npm run tslint && npm audit",
+    "test": "eslint --ignore-path .eslintignore . && tsc test/typescript/*.ts && mocha && npm run tslint && npm audit",
     "test-verbose": "env DEBUG='*,-mocha:*' npm run test",
     "test-live": "NOCK_OFF=true mocha",
     "test-live-verbose": "env DEBUG='*,-mocha:*' npm run test-live",

test/mocha.opts

@@ -1,2 +1,3 @@
+--exclude test/typescript/*.js
 --recursive
 --timeout 10000

test/typescript/cloudant.ts

@@ -0,0 +1,17 @@
+// Copyright © 2018 IBM Corp. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Ensure Cloudant type declaration files can be imported without error.
+
+export import cloudant = require('../../types/index');

types/index.d.ts

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 import * as nano from 'nano';
-import CoreOptions from "request";
+import { CoreOptions } from 'request';
 
 declare function cloudant(
     config: cloudant.Configuration | string,