Development (#2)

* Add code and tests

* Allow plugins to be loaded from an absolute or relative path

* Add test to load a plugin from a custom path

Author: spezifant

CHANGES.md

@@ -1,5 +1,5 @@
 # 4.1.2 (2019-07-29)
-- [NEW] Plugins can now be loaded from outside of the 'plugins/' directory
+- [FIXED] Plugins can now be loaded from outside of the 'plugins/' directory
 
 # 4.1.1 (2019-06-17)
 - [FIXED] Remove unnecessary `npm-cli-login` dependency.

lib/client.js

@@ -102,7 +102,7 @@ class CloudantClient {
           var pluginName = Object.keys(plugin)[0];
 
           try {
-            Plugin = require('../plugins/' + pluginName);
+            Plugin = require(self._buildPluginPath(pluginName));
           } catch (e) {
             throw new Error(`Failed to load plugin - ${e.message}`);
           }
@@ -120,7 +120,7 @@ class CloudantClient {
           }
 
           try {
-            Plugin = require('../plugins/' + plugin);
+            Plugin = require(self._buildPluginPath(plugin));
           } catch (e) {
             throw new Error(`Failed to load plugin - ${e.message}`);
           }

test/client.js

@@ -102,6 +102,14 @@ describe('CloudantClient', function() {
       assert.equal(cloudantClient._buildPluginPath('/plugins/dummy-plugin'), '/plugins/dummy-plugin');
     });
 
+    it('load plugin from custom path', function() {
+      let ownPlugin = 'test/fixtures/testplugin.js';
+      var cloudantClient = new Client({
+        plugins: [ ownPlugin ]
+      });
+      assert.equal(cloudantClient._plugins.length, 1);
+    });
+
     it('adds cookie authentication plugin if no other plugins are specified', function() {
       var cloudantClient = new Client();
       assert.equal(cloudantClient._plugins.length, 1);

test/fixtures/testplugin.js

@@ -0,0 +1,23 @@
+// Copyright © 2017, 2018 IBM Corp. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+'use strict';
+
+const BasePlugin = require('../../plugins/base.js');
+
+class TestPlugin extends BasePlugin {
+}
+
+TestPlugin.id = 'test';
+
+module.exports = TestPlugin;