Don't authenticate basic access requests if credentials are missing

Author: smithsz

src/cloudant/client_session.py

@@ -120,8 +120,12 @@ def request(self, method, url, **kwargs):
         Overrides ``requests.Session.request`` to provide basic access
         authentication.
         """
+        auth = None
+        if self._username is not None and self._password is not None:
+            auth = (self._username, self._password)
+
         return super(BasicSession, self).request(
-            method, url, auth=(self._username, self._password), **kwargs)
+            method, url, auth=auth, **kwargs)
 
 
 class CookieSession(ClientSession):

tests/unit/client_tests.py

@@ -35,6 +35,7 @@
 from cloudant import cloudant, cloudant_bluemix, couchdb, couchdb_admin_party
 from cloudant.client import Cloudant, CouchDB
 from cloudant.client_session import BasicSession, CookieSession
+from cloudant.database import CloudantDatabase
 from cloudant.error import CloudantArgumentError, CloudantClientException
 from cloudant.feed import Feed, InfiniteFeed
 
@@ -246,6 +247,31 @@ def test_session_basic(self, m_req):
 
         self.assertEquals(all_dbs, ['animaldb'])
 
+    @mock.patch('cloudant.client_session.Session.request')
+    def test_session_basic_with_no_credentials(self, m_req):
+        """
+        Test using basic access authentication with no credentials.
+        """
+        m_response_ok = mock.MagicMock()
+        type(m_response_ok).status_code = mock.PropertyMock(return_value=200)
+        m_req.return_value = m_response_ok
+
+        client = Cloudant(None, None, url=self.url, use_basic_auth=True)
+        client.connect()
+        self.assertIsInstance(client.r_session, BasicSession)
+
+        db = client['animaldb']
+
+        m_req.assert_called_once_with(
+            'HEAD',
+            self.url + '/animaldb',
+            allow_redirects=False,
+            auth=None,  # ensure no authentication specified
+            timeout=None
+        )
+
+        self.assertIsInstance(db, CloudantDatabase)
+
     @mock.patch('cloudant.client_session.Session.request')
     def test_change_credentials_basic(self, m_req):
         """