Skip to content

Commit 0d9b349

Browse files
fix: use-domain-name keyword to define remotes URL
1 parent 780361c commit 0d9b349

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ To enable verbose logging add folowing in webpack config:
155155
|-----------------------------------------:|:--------------------:|:-------------------:|:------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
156156
| `disableTypeCompilation` | `boolean` | `false` | Disable compilation of types |
157157
| `disableDownladingRemoteTypes` | `boolean` | `false` | Disable downloading of remote types |
158-
| `cloudbedsRemoteManifestsBaseUrl` | `string` | `'/remotes/dev-ga'` | Base URL for remote manifest files (a.k.a remote entry configs) that is specific to Cloudbeds microapps <br><br> _ Examples:_ <br> `http://localhost:4480/remotes/dev` <br> `https://cb-front.cloudbeds-dev.com/remotes/[env]` <br> `use-devbox-name` |
158+
| `cloudbedsRemoteManifestsBaseUrl` | `string` | `'/remotes/dev-ga'` | Base URL for remote manifest files (a.k.a remote entry configs) that is specific to Cloudbeds microapps <br><br> _ Examples:_ <br> `http://localhost:4480/remotes/dev` <br> `https://cb-front.cloudbeds-dev.com/remotes/[env]` <br> `use-domain-name` |
159159
| `doNotUseCloudbedsRemoteManifests` | `boolean` | `false` | Disable downloading default remote manifest files for Cloudbeds microapps (`mfd-common-remote-entry.json` and `mfd-remote-entries.json` files) and download only those provided via `remoteManifestUrls` |
160160
| `downloadTypesWhenIdleIntervalInSeconds` | `number`, `-1` | `60` | Synchronize types continusouly - compile types after every compilation, download when idle with a specified delay value in seconds. <br><br> `-1` - disables continuous synchronization (compile and download will happen only on startup). |
161161
| `remoteManifestUrls` | `RemoteManifestUrls` | `{}` | URLs to remote manifest files. A manifest contains a URL to a remote entry that is substituted in runtime. Multiple remote entries is supported via `registry` field. <br><br> More details available in [this section](#templated-remote-urls) |

src/helpers/cloudbedsRemoteManifests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { ModuleFederationTypesPluginOptions, RemoteManifestUrls } from '../types
99
export function getRemoteManifestUrls(options?: ModuleFederationTypesPluginOptions): RemoteManifestUrls | undefined {
1010
if (!options?.doNotUseCloudbedsRemoteManifests) {
1111
let baseUrl = options?.cloudbedsRemoteManifestsBaseUrl;
12-
if (!baseUrl || baseUrl === 'use-devbox-name') {
12+
if (!baseUrl || baseUrl === 'use-domain-name') {
1313
baseUrl = `${CLOUDBEDS_DEV_FRONTEND_ASSETS_DOMAIN}/remotes/dev-ga`;
1414
}
1515
return {

src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export type RemoteManifestUrls = Record<'registry' | string, string>;
2626
export type ModuleFederationPluginOptions = ConstructorParameters<typeof container.ModuleFederationPlugin>[0];
2727

2828
export type ModuleFederationTypesPluginOptions = {
29-
cloudbedsRemoteManifestsBaseUrl?: string | 'use-devbox-name',
29+
cloudbedsRemoteManifestsBaseUrl?: string | 'use-domain-name',
3030
disableDownladingRemoteTypes?: boolean,
3131
disableTypeCompilation?: boolean,
3232
doNotUseCloudbedsRemoteManifests?: boolean,

0 commit comments

Comments
 (0)